Note: There are a few cases of duplicates in user autocompletion which are being worked on.

ICO crash [mozilla::image::Decoder::Write]

VERIFIED FIXED in Firefox 15

Status

()

Core
ImageLib
--
critical
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: posidron, Assigned: bbondy)

Tracking

({crash, testcase})

Trunk
mozilla15
crash, testcase
Points:
---

Firefox Tracking Flags

(firefox12 unaffected, firefox13 affected, firefox14 affected, firefox15 verified)

Details

(crash signature)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 620160 [details]
testcase
(Reporter)

Comment 1

5 years ago
Created attachment 620161 [details]
callstack
(Reporter)

Updated

5 years ago
status-firefox12: --- → unaffected
status-firefox15: --- → affected

Updated

5 years ago
Crash Signature: [@ mozilla::image::Decoder::Write]
Component: Graphics → ImageLib
Keywords: regressionwindow-wanted
QA Contact: thebes → imagelib

Comment 2

5 years ago
Browser does not crash in Windows build.
However, the following error message appears in Error console without showing image.

Error: Image corrupt or truncated: https://bugzilla.mozilla.org/attachment.cgi?id=620160
Source file: https://bugzilla.mozilla.org/attachment.cgi?id=620160

FYI,
this starts from the following range.
(central)
Something image displayed:
http://hg.mozilla.org/mozilla-central/rev/e6893e6c883f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111104 Firefox/10.0a1 ID:20111104020439
Error message appears in Error console without showing image:
http://hg.mozilla.org/mozilla-central/rev/5ebd59b5a94a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111104 Firefox/10.0a1 ID:20111104112939
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e6893e6c883f&tochange=5ebd59b5a94a

(inbound)
Something image displayed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c535d936df7f
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111103 Firefox/10.0a1 ID:20111104035242
Error message appears in Error console without showing image:
http://hg.mozilla.org/integration/mozilla-inbound/rev/dd25b9224c76
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a1) Gecko/20111104 Firefox/10.0a1 ID:20111104070042
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c535d936df7f&tochange=dd25b9224c76

Comment 3

5 years ago
The error message on Windows is bug 704421, but the crash on Mac is a different issue.
(Assignee)

Updated

5 years ago
Assignee: nobody → netzen
(Assignee)

Comment 4

5 years ago
Created attachment 620555 [details] [diff] [review]
Patch v1.

Basically we were not carrying over the decoder errors, only the data errors
Attachment #620555 - Flags: review?(joe)
(Assignee)

Comment 5

5 years ago
The testcase doesn't crash on osx by the way, but I can see from the callstack that the problem is with us not carrying over the decoder error. 

The error message found for the regression range is not a bug but an invalid icon file that we shouldn't handle.  The test case icon doesn't work in IE nor Chrome.

Updated

5 years ago
Keywords: regressionwindow-wanted, testcase
(Reporter)

Comment 6

5 years ago
The testcase works on osx. It's the platform on which I have tested it.
Keywords: testcase
(Assignee)

Comment 7

5 years ago
I loaded the test case there and could not reproduce, but the problem seems pretty clear from the callstack.  Once this lands maybe you could verify it since I can't reproduce the crash myself.
(Reporter)

Comment 8

5 years ago
Applied the patch to my trunk build but shows no affect.
(Assignee)

Comment 9

5 years ago
Still crashes after building image? 
Could you attach a new callstack?
(Assignee)

Comment 10

5 years ago
Comment on attachment 620555 [details] [diff] [review]
Patch v1.

Cancelling review for now since it still crashes.
Attachment #620555 - Flags: review?(joe)
(Reporter)

Comment 11

5 years ago
The callstack is the same.
(Assignee)

Comment 12

5 years ago
I reproduced this on OSX with a debug build; however...  

I then applied the fix and I could no longer reproduce.  I then popped off the fix and I could reproduce again.  I then pushed the fix and could not reproduce again.  I then just for good measure popped one last time and could reproduce again.

It also would not make any logical sense to me how the error could happen with the fix applied. 

Are you sure that you applied the fix and built properly?
(Reporter)

Comment 13

5 years ago
Hmm,

$ hg qapplied
4 A bug746891.patch

Applied without errors, compiled without errors (make -sf client.mk build) but still can reproduce it.
(Reporter)

Comment 14

5 years ago
Ops, wrong patch!
(Reporter)

Comment 15

5 years ago
Yes, fixed! Sorry for the trouble and confusion.
(Assignee)

Comment 16

5 years ago
no problem, it happens :)
(Assignee)

Updated

5 years ago
Attachment #620555 - Flags: review?(joe)
Comment on attachment 620555 [details] [diff] [review]
Patch v1.

Review of attachment 620555 [details] [diff] [review]:
-----------------------------------------------------------------

lovely
Attachment #620555 - Flags: review?(joe) → review+
(Assignee)

Comment 18

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/4eda2c7b640c
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/4eda2c7b640c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
status-firefox15: affected → ---
(Assignee)

Updated

5 years ago
status-firefox13: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → fixed
Keywords: verifyme
Not able to reproduce the crash on FF 13.0.1, FF 14.0.1 and Nightly 2012-05-01 on Mac OS X 10.6.8.
Is there something qa can do to verify this fix ?
(Assignee)

Comment 21

5 years ago
I think you have to use a debug build and then load the test case image attached to this bug.  Any platform should be fine.
Thanks Brian.
Able to see the crash on 2012-05-01-mozilla-central-debug on Win 7, Ubuntu 12.04 and Mac OS X 10.6.
No crashes on 2012-08-18-mozilla-beta-debug. Verified fixed.
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
Keywords: verifyme
OS: Mac OS X → All
QA Contact: paul.silaghi
Hardware: x86_64 → All
You need to log in before you can comment on or make changes to this bug.