Last Comment Bug 751129 - "ASSERTION: Whoever was caching this font group should have called UpdateFontList on it", take 2
: "ASSERTION: Whoever was caching this font group should have called UpdateFont...
Status: RESOLVED FIXED
: assertion, regression, testcase
Product: Core
Classification: Components
Component: Canvas: 2D (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Jonathan Kew (:jfkthame)
:
Mentors:
Depends on:
Blocks: 343943 379903 703100
  Show dependency treegraph
 
Reported: 2012-05-02 05:28 PDT by Jesse Ruderman
Modified: 2012-05-04 03:30 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (451 bytes, text/html)
2012-05-02 05:28 PDT, Jesse Ruderman
no flags Details
patch, ensure the font list is updated (1.69 KB, patch)
2012-05-02 06:24 PDT, Jonathan Kew (:jfkthame)
roc: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-05-02 05:28:48 PDT
Created attachment 620265 [details]
testcase

###!!! ASSERTION: Whoever was caching this font group should have called UpdateFontList on it: '!mUserFontSet || mCurrGeneration == GetGeneration()', file ../../../gfx/thebes/gfxFont.h, line 3002

(Similar to bug 745699, which was fixed two weeks ago.)
Comment 1 Jonathan Kew (:jfkthame) 2012-05-02 06:24:39 PDT
Created attachment 620280 [details] [diff] [review]
patch, ensure the font list is updated

Ah yes - the use of ctx.measureText("") bypasses the fix that was landed for bug 745699, as the zero-length string doesn't cause us to actually create a text run. So we need to explicitly make sure the font list is updated before accessing its first font's metrics here.
Comment 3 Ed Morley [:emorley] 2012-05-04 03:30:33 PDT
https://hg.mozilla.org/mozilla-central/rev/47bf5e590a0c

Note You need to log in before you can comment on or make changes to this bug.