751176 - OMTC Linux: Canvas and Video blinks when using OMTC and layers acceleration on Linux

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

To enable OMTC on Linux: 
 - apply attachment 618255 [details] [diff] [review] from bug 722012 (not landed yet)
 - set the environment variable MOZ_USE_OMTC
 - set the pref layers.acceleration.force-enabled to true

Videos such as http://www.mozilla.org/en-US/firefox/11.0/whatsnew/ blink as well as canvas games like http://canvasrider.com/tracks/random or http://superbitboy.com/ .

The bad behaviour is similar for canvas and video so I opened only one bugzilla entry, maybe they do need separate bugs.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Fixes blinking of video and canvas elements with OMTC on Linux.

OnExposeEvent was not handled correctly in the case of OMTC. I think this fix is important because other OMTC-related fixes will most likely depend on it.

Needs attachment 618255 [details] [diff] [review].

Comment 2

[Nicolas Silva [:nical]]

Attachment 621094 [details] [diff] seems to also fix bug 751180.

Comment 3

[Constantine]

(In reply to Nicolas Silva [:nical] from comment #2)
> Attachment 621094 [details] [diff] seems to also fix bug 751180.
Yes, it fixes WebGL and all blinking for me but only with gfx.xrender.enabled=false. With xrender enabled the patch doesn't fix anything. The problem is probably NVidia-specific.

Comment 4

[Nicolas Silva [:nical]]

(In reply to konstartyom from comment #3)
> (In reply to Nicolas Silva [:nical] from comment #2)
> > Attachment 621094 [details] [diff] seems to also fix bug 751180.
> Yes, it fixes WebGL and all blinking for me but only with
> gfx.xrender.enabled=false. With xrender enabled the patch doesn't fix
> anything. The problem is probably NVidia-specific.

It also still blinks if xrender is enabled on my laptop (intel integrated gpu).

Comment 5

[Nicolas Silva [:nical]]

It is very likely that we just don't try to support xrender with omtc. Right now the tendency is to get rid of xrender anyway.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecd6235510e1

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ecd6235510e1