Closed Bug 751217 Opened 8 years ago Closed 8 years ago

In SeaMonkey, the Delete button in the Lightning Task Actions Toolbar doesn't have an icon because it uses mail-toolbar.png

Categories

(Calendar :: Lightning: SeaMonkey Integration, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

In SeaMonkey, the Delete button in the Lightning Task Actions Toolbar doesn't have an icon because it uses chrome://messenger/skin/icons/mail-toolbar.png. SeaMonkey doesn't have this file and even if it did it would be highly unlikely that we would have the icons in the same order or size.

The fix is to use an identical icon from chrome://calendar/skin/toolbar-aero.png.
Attached patch Patch v1.0 Proposed fix. (obsolete) — Splinter Review
Tested on SeaMonkey Trunk and Thunderbird Nightly on Windows7.

> -#task-actions-toolbar > #calendar-add-task-button {
> -  list-style-image: url(chrome://calendar/skin/toolbar-small-aero.png);

#calendar-add-task-button can never be a child of #task-actions-toolbar.
Attachment #620352 - Flags: review?(philipp)
Attachment #620352 - Flags: feedback?(richard.marti)
Comment on attachment 620352 [details] [diff] [review]
Patch v1.0 Proposed fix.

This looks good on TB.

Please can you instead of removing the whole #task-actions-toolbar > #calendar-add-task-button {... only remove #task-actions-toolbar > ? Then it puts again correctly on the #calendar-add-task-button the aero icon. This must be come in with a to enthusiastic copy/paste by me :(.
Attachment #620352 - Flags: feedback?(richard.marti) → feedback+
Comment on attachment 620352 [details] [diff] [review]
Patch v1.0 Proposed fix.

Do you mind doing the review while you are at it? :)
Attachment #620352 - Flags: review?(philipp) → review?(richard.marti)
> Please can you instead of removing the whole #task-actions-toolbar > #calendar-
> add-task-button {... only remove #task-actions-toolbar > ? Then it puts again
> correctly on the #calendar-add-task-button the aero icon. This must be come
> in with a to enthusiastic copy/paste by me :(.
Fixed.
Attachment #620352 - Attachment is obsolete: true
Attachment #620352 - Flags: review?(richard.marti)
Attachment #620625 - Flags: review?(richard.marti)
Comment on attachment 620625 [details] [diff] [review]
Patch v1.1 fix rule for #calendar-add-task-button. f=paenglab

This looks good.

Please can you add here a #task-addition-box > box > #calendar-add-task-button? Then the aero icon is really used.

+#calendar-add-task-button {
   list-style-image: url(chrome://calendar/skin/toolbar-small-aero.png);
 }

With this fixed r+

Thank you
Attachment #620625 - Flags: review?(richard.marti) → review+
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/c97558cdadef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.7
You need to log in before you can comment on or make changes to this bug.