751217 - In SeaMonkey, the Delete button in the Lightning Task Actions Toolbar doesn't have an icon because it uses mail-toolbar.png

Status: RESOLVED FIXED

(Calendar :: Lightning: SeaMonkey Integration, defect)

Description

[Philip Chee]

In SeaMonkey, the Delete button in the Lightning Task Actions Toolbar doesn't have an icon because it uses chrome://messenger/skin/icons/mail-toolbar.png. SeaMonkey doesn't have this file and even if it did it would be highly unlikely that we would have the icons in the same order or size.

The fix is to use an identical icon from chrome://calendar/skin/toolbar-aero.png.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

Tested on SeaMonkey Trunk and Thunderbird Nightly on Windows7.

> -#task-actions-toolbar > #calendar-add-task-button {
> -  list-style-image: url(chrome://calendar/skin/toolbar-small-aero.png);

#calendar-add-task-button can never be a child of #task-actions-toolbar.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 620352 [details] [diff] [review]
Patch v1.0 Proposed fix.

This looks good on TB.

Please can you instead of removing the whole #task-actions-toolbar > #calendar-add-task-button {... only remove #task-actions-toolbar > ? Then it puts again correctly on the #calendar-add-task-button the aero icon. This must be come in with a to enthusiastic copy/paste by me :(.

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 620352 [details] [diff] [review]
Patch v1.0 Proposed fix.

Do you mind doing the review while you are at it? :)

Comment 4

[Philip Chee]

Attachment: Patch v1.1 fix rule for #calendar-add-task-button. f=paenglab

> Please can you instead of removing the whole #task-actions-toolbar > #calendar-
> add-task-button {... only remove #task-actions-toolbar > ? Then it puts again
> correctly on the #calendar-add-task-button the aero icon. This must be come
> in with a to enthusiastic copy/paste by me :(.
Fixed.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 620625 [details] [diff] [review]
Patch v1.1 fix rule for #calendar-add-task-button. f=paenglab

This looks good.

Please can you add here a #task-addition-box > box > #calendar-add-task-button? Then the aero icon is really used.

+#calendar-add-task-button {
   list-style-image: url(chrome://calendar/skin/toolbar-small-aero.png);
 }

With this fixed r+

Thank you

Comment 6

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/c97558cdadef