Cleanup nsHTMLEditRules::RemoveEmptyNodes()

RESOLVED FIXED in mozilla15

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 620440 [details] [diff] [review]
Patch v1
Attachment #620440 - Flags: review?(ehsan)
Comment on attachment 620440 [details] [diff] [review]
Patch v1

Review of attachment 620440 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +8047,5 @@
>  nsresult
> +nsHTMLEditRules::SelectionEndpointInNode(nsINode *node, bool *aResult)
> +{
> +  NS_ENSURE_TRUE(node && aResult, NS_ERROR_NULL_POINTER);
> +  nsIDOMNode* aNode = node->AsDOMNode();

Please leave the name of the argument as aNode, rename the local variable to |node|, and change all of the usages in the function.
Attachment #620440 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
OK.
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/896a6869b2d3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.