Closed
Bug 751323
Opened 12 years ago
Closed 12 years ago
Cleanup nsHTMLEditRules::RemoveEmptyNodes()
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
15.59 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #620440 -
Flags: review?(ehsan)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 620440 [details] [diff] [review] Patch v1 Review of attachment 620440 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/html/nsHTMLEditRules.cpp @@ +8047,5 @@ > nsresult > +nsHTMLEditRules::SelectionEndpointInNode(nsINode *node, bool *aResult) > +{ > + NS_ENSURE_TRUE(node && aResult, NS_ERROR_NULL_POINTER); > + nsIDOMNode* aNode = node->AsDOMNode(); Please leave the name of the argument as aNode, rename the local variable to |node|, and change all of the usages in the function.
Attachment #620440 -
Flags: review?(ehsan) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
OK.
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/896a6869b2d3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•