Last Comment Bug 751323 - Cleanup nsHTMLEditRules::RemoveEmptyNodes()
: Cleanup nsHTMLEditRules::RemoveEmptyNodes()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-02 13:00 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-05-05 10:30 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (15.59 KB, patch)
2012-05-02 13:00 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-05-02 13:00:01 PDT
Created attachment 620440 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-05-02 17:32:40 PDT
Comment on attachment 620440 [details] [diff] [review]
Patch v1

Review of attachment 620440 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +8047,5 @@
>  nsresult
> +nsHTMLEditRules::SelectionEndpointInNode(nsINode *node, bool *aResult)
> +{
> +  NS_ENSURE_TRUE(node && aResult, NS_ERROR_NULL_POINTER);
> +  nsIDOMNode* aNode = node->AsDOMNode();

Please leave the name of the argument as aNode, rename the local variable to |node|, and change all of the usages in the function.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-05-04 03:09:59 PDT
OK.
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-05-05 10:30:16 PDT
https://hg.mozilla.org/mozilla-central/rev/896a6869b2d3

Note You need to log in before you can comment on or make changes to this bug.