751334 - Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called. (browser_514751.js)

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

A redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called, since we only call TabView.uninit when delayedStartup was called. The extra TabView.init call shouldn't be needed, since browser-tabview.js listens for SSWindowStateReady.

Comment 1

[Dão Gottwald [:dao]]

The leak shows up here:

[browser/components/sessionstore/test/browser_514751.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 620452 [details] [diff] [review]
patch

Review of attachment 620452 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks for spotting this. We indeed don't need this anymore now that we listen for SSWindowStateReady.

Comment 3

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d5571baeb933

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d5571baeb933