Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called. (browser_514751.js)

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({mlk})

Trunk
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 620452 [details] [diff] [review]
patch

A redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called, since we only call TabView.uninit when delayedStartup was called. The extra TabView.init call shouldn't be needed, since browser-tabview.js listens for SSWindowStateReady.
Attachment #620452 - Flags: review?(ttaubert)
(Assignee)

Comment 1

5 years ago
The leak shows up here:

[browser/components/sessionstore/test/browser_514751.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
(Assignee)

Updated

5 years ago
Attachment #620452 - Flags: review?(paul)
Comment on attachment 620452 [details] [diff] [review]
patch

Review of attachment 620452 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks for spotting this. We indeed don't need this anymore now that we listen for SSWindowStateReady.
Attachment #620452 - Flags: review?(ttaubert) → review+
(Assignee)

Updated

5 years ago
Attachment #620452 - Flags: review?(paul)
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d5571baeb933
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/d5571baeb933
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 752456
Summary: Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called → Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called. (browser_514751.js)
You need to log in before you can comment on or make changes to this bug.