Closed Bug 751334 Opened 8 years ago Closed 8 years ago

Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called. (browser_514751.js)

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 15

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: memory-leak)

Attachments

(1 file)

Attached patch patchSplinter Review
A redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called, since we only call TabView.uninit when delayedStartup was called. The extra TabView.init call shouldn't be needed, since browser-tabview.js listens for SSWindowStateReady.
Attachment #620452 - Flags: review?(ttaubert)
The leak shows up here:

[browser/components/sessionstore/test/browser_514751.js]
  1 window(s) [url = chrome://browser/content/browser.xul]
  1 window(s) [url = about:blank]
Attachment #620452 - Flags: review?(paul)
Comment on attachment 620452 [details] [diff] [review]
patch

Review of attachment 620452 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks for spotting this. We indeed don't need this anymore now that we listen for SSWindowStateReady.
Attachment #620452 - Flags: review?(ttaubert) → review+
Attachment #620452 - Flags: review?(paul)
https://hg.mozilla.org/mozilla-central/rev/d5571baeb933
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Summary: Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called → Redundant TabView.init call in restoreWindow leaks the browser window when the window closes before delayedStartup was called. (browser_514751.js)
You need to log in before you can comment on or make changes to this bug.