Closed Bug 751370 Opened 9 years ago Closed 9 years ago
Do not use accelerated layers for small popups windows on Linux
Right now on Linux, either all windows are accelerated or none. We don't need to accelerate small popup windows such as menus. It is not extremely important but it would help debugging GLContext related problems.
This patch feels almost too simple. Is it worth adding a pref (something like layers.acceleration.accelerate-popups)? I don't see why we would want accelerated layers for these windows...
Attachment #620698 - Flags: review?(bgirard)
(In reply to Nicolas Silva [:nical] from comment #1) > Created attachment 620698 [details] [diff] [review] > Disables layers acceleration for small popups like menus and combo boxes. > > This patch feels almost too simple. Is it worth adding a pref (something > like layers.acceleration.accelerate-popups)? I don't see why we would want > accelerated layers for these windows... I do not think it's worth adding a pref.
Fixed a stupid mistake in the previous attachment. This one works.
Summary: Not use accelerated layers for small popups windows on Linux → Do not use accelerated layers for small popups windows on Linux
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Hmm, will this also affect XUL <panel>s? nsWidgetInitData.h seems to imply that it will (nsPopupType panel)... I'd suspect that we still want those accelerated since they can hold arbitrarily complex stuff...
(In reply to Justin Dolske [:Dolske] from comment #6) > Hmm, will this also affect XUL <panel>s? > It will.
Should we back this patch out? I don't know what a xul panel is. It looks like this problem could be solved by making GetShouldAccelerate vertual and overriding it in nsWindow taking into account the type of the popup using with nsWindow::PopupType(). I can do this if someone backs the patch out, or fix it as another patch on top of it. Are there other popup types that we would want to accelerate ?
I (obviously) just filed bug 758048 for the <panel> issue. I don't think a backout is needed, but we should fix it at some point. Seems like an easy fix anyway? (hint hint:)
You need to log in before you can comment on or make changes to this bug.