The default bug view has changed. See this FAQ.

Do not use accelerated layers for small popups windows on Linux

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics: Layers
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Right now on Linux, either all windows are accelerated or none. We don't need to accelerate small popup windows such as menus. It is not extremely important but it would help debugging GLContext related problems.
(Assignee)

Updated

5 years ago
Assignee: nobody → nsilva
(Assignee)

Comment 1

5 years ago
Created attachment 620698 [details] [diff] [review]
Disables layers acceleration for small popups like menus and combo boxes.

This patch feels almost too simple. Is it worth adding a pref (something like layers.acceleration.accelerate-popups)? I don't see why we would want accelerated layers for these windows...
Attachment #620698 - Flags: review?(bgirard)
(In reply to Nicolas Silva [:nical] from comment #1)
> Created attachment 620698 [details] [diff] [review]
> Disables layers acceleration for small popups like menus and combo boxes.
> 
> This patch feels almost too simple. Is it worth adding a pref (something
> like layers.acceleration.accelerate-popups)? I don't see why we would want
> accelerated layers for these windows...

I do not think it's worth adding a pref.

Updated

5 years ago
Attachment #620698 - Flags: review?(bgirard) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 621340 [details] [diff] [review]
Disables layers acceleration for small popups like menus and combo boxes.

Fixed a stupid mistake in the previous attachment. This one works.
Attachment #620698 - Attachment is obsolete: true
Attachment #621340 - Flags: review?(bgirard)

Updated

5 years ago
Attachment #621340 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/96451c3a2511
Summary: Not use accelerated layers for small popups windows on Linux → Do not use accelerated layers for small popups windows on Linux
https://hg.mozilla.org/mozilla-central/rev/96451c3a2511
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Hmm, will this also affect XUL <panel>s?

nsWidgetInitData.h seems to imply that it will (nsPopupType panel)... I'd suspect that we still want those accelerated since they can hold arbitrarily complex stuff...

Comment 7

5 years ago
(In reply to Justin Dolske [:Dolske] from comment #6)
> Hmm, will this also affect XUL <panel>s?
> 

It will.
(Assignee)

Comment 8

5 years ago
Should we back this patch out?

I don't know what a xul panel is.
It looks like this problem could be solved by making GetShouldAccelerate vertual and overriding it in nsWindow taking into account the type of the popup using with nsWindow::PopupType().

I can do this if someone backs the patch out, or fix it as another patch on top of it.

Are there other popup types that we would want to accelerate ?
Blocks: 758048
I (obviously) just filed bug 758048 for the <panel> issue. I don't think a backout is needed, but we should fix it at some point. Seems like an easy fix anyway? (hint hint:)
You need to log in before you can comment on or make changes to this bug.