751410 - /crash_trends report - y-axis dates & versions do not properly align with the graph data

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - bug graph data not properly aligned

Filtering the report on large date ranges causes the graph data to no properly align with the version/date data in the in y-axis

Steps to reproduce:
1. goto the /crash_trends report
2. set the filter criteria to a product with a lot of data - select a large date range.

Expected:
Dates & version information is aligned with the graph data.

Comment 1

[[github robot]]

Commit pushed to bug751410 at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2ebc8c199d4a8649763967b1d2c2531548a5114e
Bug 751410 - Changing data format to properly provide dates to front-end.

Comment 2

[Schalk Neethling [:espressive]]

Attachment: Revised UI for crash trends graph

Because of the changes that needed to be made to the data format in order to allow for data over dynamic date ranges and, the fact that data is not available for every day in a date range, the UI of the graph has changed slightly.

With that said, each point is (circle) is hoverable, as can be seen in the screen grab, and will show the number of crashes that occurred and how old the build was.

Comment 3

[Schalk Neethling [:espressive]]

Pull request sent for the above changes:
https://github.com/mozilla/socorro/pull/684

Comment 4

[Robert Kaiser]

Comment on attachment 640074 [details]
Revised UI for crash trends graph

This looks good to me, even though I don't understand this report as well as chofmann does ;-)

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopened: not sure if this should be filed as a separate bug or is associated with the latest pull request(s) associated with this bug but there is some new behavior (a regression).

When hovering over the crash trends data in the graph the graph displays the numbers associated with the total crashes and how many days that is aggregated over.

+ reproducible:
 - on Linux & OSX: Firefox RC and Beta
 - on dev & staging environments

Steps to reproduce:
1. goto https://crash-stats.mozilla.com/crash_trends
2. using your mouse hover over the crash data in the graph

Expected:
- hovering over the lines on the graph should display only one overlay at a time.

Actual:
- the overlays aggregate on the webpage and do not go away.
http://screencast.com/t/4gjlVj3bMgG3

Comment 6

[Lonnen :lonnen]

It's not just the points that are hoverable, the whole region of the bar will provide the info on demand. The points are just visual clutter. Can you set `show:false` on the points and remove them?

Comment 7

[Schalk Neethling [:espressive]]

:lonnen, there has been a bunch of changes to the graph since the screen shot in comment 5. You can see these in comment 4. For the graph in comment 5, I could have hidden the points but, for the new graph the bars do not stack anymore and hence the points needs to be visible.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d29527e28fe40d5baa5b840cf61d8411fc5ea06e
Bug 751410 - Changing data format to properly provide dates to front-end.

Comment 9

[Matt Brandt [:mbrandt]]

Spicy hot-sauce -- lgtm. QA verified on stage:
1. data aligns properly on the graph (comment 0)
2. meta data clutter has been fixed (comment 5)
3. filter on ranges that are incorrect works as expected with error messages: begin date > end date
3. filtering on a product and/or date range without data

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened

Reopening:

I'm not sure if this is related but on production I'm seeing miss-alignment (or missing y-axis values).

http://screencast.com/t/UTxvxjev2My

Steps to reproduce:
1. goto https://crash-stats.mozilla.com/crash_trends
2. filter on:
  From: 01/05/2012
  To:   26/09/2012
  Product: Firefox
  Version: 16.0a1
3. scroll to the bottom of the crash trends graph

Actual:
The y-axis values do not align properly -- see screenshot

Expected:
The should :-)

Comment 11

[Schalk Neethling [:espressive]]

Hey Matt,

Ok, I will have to look at this in more detail. For one thing though, the dates returned to the front end are not sorted at all which would make scanning the data very difficult, perhaps we should open another bug for that as it should not be done on the UI side?

Comment 12

[Schalk Neethling [:espressive]]

I can reproduce this on DEV so, gonna make debugging and fixing this a lot easier.

Comment 13

[Matt Brandt [:mbrandt]]

(In reply to Schalk Neethling [:espressive] from comment #12)
> I can reproduce this on DEV so, gonna make debugging and fixing this a lot
> easier.

Oops, sorry I forgot to note that it's reproducible on dev/stage/prod :-) thanks!

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c790f829e46c95d86406b32e61af10abbf254bb8
ensure that dates align with axis fixes bug 751410

https://github.com/mozilla/socorro/commit/25d232d357c68703e3aa3ff50d0595eacb5dd69b
Merge pull request #850 from ossreleasefeed/crash-trends-ensure-alignment-correct-751410

ensure that dates align with axis fixes bug 751410

Comment 15

[Schalk Neethling [:espressive]]

sent and merged: https://github.com/mozilla/socorro/pull/850

Dates should now align independent of the number of results returned.

Comment 16

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on dev (doesn't appear to have landed on stage yet) -- graph data is properly aligned with the y-axis points