751425 - shell exit code for runtime error differs between -e and -f

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

> ./js -e "z()"

1
http://hg.mozilla.org/mozilla-central/annotate/8899c0604bd1/js/src/shell/js.cpp#l4689

> ./js -f ~/Desktop/z.js

3
http://hg.mozilla.org/mozilla-central/annotate/8899c0604bd1/js/src/shell/js.cpp#l480

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Fix JS shell exit status on -e script failure

I think EXIT_FAILURE is intended to only be used for the shell machinery (argument parsing, etc.); any actual JS error should be EXITCODE_RUNTIME_ERROR (or one of the more specific ones.)

Comment 2

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3656a0a559b2

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3656a0a559b2