Closed Bug 751435 Opened 12 years ago Closed 12 years ago

Make role strings consistent

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: davidb, Unassigned)

Details

I don't know why this happens, which makes me nervous.

Eitan trims whitespace over in bug 751428. This bug is a spin off to track down how whitespace can happen here. Maybe we should add debug info to where we call getStringRole(aRole) in our mochitests (common.js) to help us diagnose when this happens.
Summary: A space can be introduced in when calling getStringRole (nsAccessibilityService::GetStringRole)? → Can calling getStringRole (nsAccessibilityService::GetStringRole) introduce a space?
I don't trim whitespace. There are some role names with a space in them, like "check menu item", and some that don't, like "menuitem". There is definately a style inconsistency here, but no artifact whitespace is produced.
Oh! OK thanks for the explanation. I'll leave it open for now with a new title. Possible GFB.
Summary: Can calling getStringRole (nsAccessibilityService::GetStringRole) introduce a space? → Make role strings consistent
role strings are consistent to role constant names. What you need to do here is to make role constant names consistent and then take care about strings.
Severity: normal → minor
(Correct my terminology if need)

Do you just want to remove spaces from role constants in rolemap.h: 40 items found, "internal frame", "text leaf", "accel label", "check menu item", and etc... to become "internalframe", "textleaf", "accellabel", "checkmenuitem" ...

and then match changes into the verbosityRoleMap in UtteranceGenerator.jsm?
(In reply to Mark Capella [:capella] from comment #4)
> (Correct my terminology if need)
> 
> Do you just want to remove spaces from role constants in rolemap.h: 40 items
> found, "internal frame", "text leaf", "accel label", "check menu item", and
> etc... to become "internalframe", "textleaf", "accellabel", "checkmenuitem"
> ...

no, at least me

But roles constant names aren't consistent. We might want to change them (and perhaps remove unsused ones).

Let's get feedback from David since he's the bug author.
I don't even know what this bug is about anymore.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.