Closed Bug 751437 Opened 9 years ago Closed 9 years ago

Weird artifacts under the progress bar

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: reuben, Assigned: reuben)

Details

(Whiteboard: [good first bug][mentor=mstange][lang=c++])

Attachments

(2 files)

Attached video Screen recording
A weird line and a few black pixels randomly appear under the progress bar on pinstripe. See attachment. (Please ignore the parrot and the pegleg.)
I think this happens because the progress bar doesn't report its overflow in nsNativeThemeCocoa::GetWidgetOverflow.
Component: Downloads Panel → Widget: Cocoa
Product: Firefox → Core
QA Contact: downloads.panel → cocoa
Whiteboard: [good first bug][mentor=mstange][lang=c++]
Got a link to the relevant source?
Sure, the only occurrence of "nsNativeThemeCocoa::GetWidgetOverflow" in the source: http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsNativeThemeCocoa.mm#2387
What should be the value of the overflow here? Currently the code inside nsNativeThemeCocoa::GetWidgetOverflow is about "focus ring" but AFAICT, there is no focus ring for the progress element.
It looks like the white 1px shadow under the progress bar is the only part that overflows, but one should test different sizes and states, maybe there's also overflow to the other sides. But as a first try I'd just extend the the overflow rect's height by 1 pixel (and not add the focus ring margin for progress bars).
Attached patch PatchSplinter Review
(In reply to Markus Stange from comment #1)
> I think this happens because the progress bar doesn't report its overflow in
> nsNativeThemeCocoa::GetWidgetOverflow.

Interesting. The shadow is 2 pixels high.
Attachment #621144 - Flags: review?(mstange)
Comment on attachment 621144 [details] [diff] [review]
Patch

Great!
Attachment #621144 - Flags: review?(mstange) → review+
Assignee: nobody → reuben.morais
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/dbc45d173470
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/dbc45d173470
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.