Last Comment Bug 751437 - Weird artifacts under the progress bar
: Weird artifacts under the progress bar
[good first bug][mentor=mstange][lang...
Product: Core
Classification: Components
Component: Widget: Cocoa (show other bugs)
: Trunk
: All Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Reuben Morais [:reuben]
: Markus Stange [:mstange]
Depends on:
  Show dependency treegraph
Reported: 2012-05-02 18:01 PDT by Reuben Morais [:reuben]
Modified: 2012-05-05 20:35 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Screen recording (163.54 KB, video/webm)
2012-05-02 18:01 PDT, Reuben Morais [:reuben]
no flags Details
Patch (2.05 KB, patch)
2012-05-04 13:08 PDT, Reuben Morais [:reuben]
mstange: review+
Details | Diff | Splinter Review

Description Reuben Morais [:reuben] 2012-05-02 18:01:57 PDT
Created attachment 620543 [details]
Screen recording

A weird line and a few black pixels randomly appear under the progress bar on pinstripe. See attachment. (Please ignore the parrot and the pegleg.)
Comment 1 Markus Stange [:mstange] 2012-05-03 01:20:07 PDT
I think this happens because the progress bar doesn't report its overflow in nsNativeThemeCocoa::GetWidgetOverflow.
Comment 2 Josh Matthews [:jdm] (on vacation until Dec 5) 2012-05-03 01:21:07 PDT
Got a link to the relevant source?
Comment 3 Markus Stange [:mstange] 2012-05-03 01:37:13 PDT
Sure, the only occurrence of "nsNativeThemeCocoa::GetWidgetOverflow" in the source:
Comment 4 Mounir Lamouri (:mounir) 2012-05-03 03:44:28 PDT
What should be the value of the overflow here? Currently the code inside nsNativeThemeCocoa::GetWidgetOverflow is about "focus ring" but AFAICT, there is no focus ring for the progress element.
Comment 5 Markus Stange [:mstange] 2012-05-03 06:09:34 PDT
It looks like the white 1px shadow under the progress bar is the only part that overflows, but one should test different sizes and states, maybe there's also overflow to the other sides. But as a first try I'd just extend the the overflow rect's height by 1 pixel (and not add the focus ring margin for progress bars).
Comment 6 Reuben Morais [:reuben] 2012-05-04 13:08:44 PDT
Created attachment 621144 [details] [diff] [review]

(In reply to Markus Stange from comment #1)
> I think this happens because the progress bar doesn't report its overflow in
> nsNativeThemeCocoa::GetWidgetOverflow.

Interesting. The shadow is 2 pixels high.
Comment 7 Markus Stange [:mstange] 2012-05-04 19:01:39 PDT
Comment on attachment 621144 [details] [diff] [review]

Comment 8 Ryan VanderMeulen [:RyanVM] 2012-05-05 09:45:14 PDT
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-05-05 20:35:10 PDT

Note You need to log in before you can comment on or make changes to this bug.