751437 - Weird artifacts under the progress bar

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Reuben Morais [:reuben]]

Attachment: Screen recording

A weird line and a few black pixels randomly appear under the progress bar on pinstripe. See attachment. (Please ignore the parrot and the pegleg.)

Comment 1

[Markus Stange [:mstange]]

I think this happens because the progress bar doesn't report its overflow in nsNativeThemeCocoa::GetWidgetOverflow.

Comment 2

[Josh Matthews [:jdm]]

Got a link to the relevant source?

Comment 3

[Markus Stange [:mstange]]

Sure, the only occurrence of "nsNativeThemeCocoa::GetWidgetOverflow" in the source: http://mxr.mozilla.org/mozilla-central/source/widget/cocoa/nsNativeThemeCocoa.mm#2387

Comment 4

[Mounir Lamouri (:mounir)]

What should be the value of the overflow here? Currently the code inside nsNativeThemeCocoa::GetWidgetOverflow is about "focus ring" but AFAICT, there is no focus ring for the progress element.

Comment 5

[Markus Stange [:mstange]]

It looks like the white 1px shadow under the progress bar is the only part that overflows, but one should test different sizes and states, maybe there's also overflow to the other sides. But as a first try I'd just extend the the overflow rect's height by 1 pixel (and not add the focus ring margin for progress bars).

Comment 6

[Reuben Morais [:reuben]]

Attachment: Patch

(In reply to Markus Stange from comment #1)
> I think this happens because the progress bar doesn't report its overflow in
> nsNativeThemeCocoa::GetWidgetOverflow.

Interesting. The shadow is 2 pixels high.

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 621144 [details] [diff] [review]
Patch

Great!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dbc45d173470

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dbc45d173470