751469 - Selection events listeners are not executed anymore since 1.7b1

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Matteo Ferretti [:zer0] [:matteo]]

The code above:

  selection.on('select', function() {
    console.log("selection!")
  })

Doesn't execute the code associated with the "select" event on 1.7b1 and later, but it works on 1.6rc2 and earlier versions of SDK.

It sounds to me like we broke the events functionality in selection during the code refactoring.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/432

Pointer to Github pull-request

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 621549 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/432

Thanks!

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If this lands today, we can get it into 1.7rc2 tomorrow for a final release in 1.7.

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/df2d5674e57a695767a79034dbfb802785f7a2d0
Merge pull request #432 from ZER0/bug751469-selection-events

fix Bug 751469 r=@gozala

Comment 5

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/075becdd649500d845fa15aea09129e6aef02bef
Merge pull request #432 from ZER0/bug751469-selection-events

fix Bug 751469 r=@gozala
(cherry picked from commit df2d5674e57a695767a79034dbfb802785f7a2d0)