Selection events listeners are not executed anymore since 1.7b1

RESOLVED FIXED in 1.7

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: zer0, Assigned: zer0)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The code above:

  selection.on('select', function() {
    console.log("selection!")
  })

Doesn't execute the code associated with the "select" event on 1.7b1 and later, but it works on 1.6rc2 and earlier versions of SDK.

It sounds to me like we broke the events functionality in selection during the code refactoring.
(Assignee)

Updated

6 years ago
Blocks: 661884
(Assignee)

Updated

6 years ago
Blocks: 665386

Updated

6 years ago
Assignee: nobody → zer0
Priority: -- → P1

Updated

6 years ago
Target Milestone: --- → 1.7
(Assignee)

Comment 1

6 years ago
Created attachment 621549 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/432

Pointer to Github pull-request
(Assignee)

Updated

6 years ago
Attachment #621549 - Flags: review?(rFobic)
Comment on attachment 621549 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/432

Thanks!
Attachment #621549 - Flags: review?(rFobic) → review+
Blocks: 752647
If this lands today, we can get it into 1.7rc2 tomorrow for a final release in 1.7.
Status: NEW → ASSIGNED

Comment 4

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/df2d5674e57a695767a79034dbfb802785f7a2d0
Merge pull request #432 from ZER0/bug751469-selection-events

fix Bug 751469 r=@gozala
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/075becdd649500d845fa15aea09129e6aef02bef
Merge pull request #432 from ZER0/bug751469-selection-events

fix Bug 751469 r=@gozala
(cherry picked from commit df2d5674e57a695767a79034dbfb802785f7a2d0)
You need to log in before you can comment on or make changes to this bug.