Closed Bug 751488 Opened 9 years ago Closed 9 years ago
Can't reload the page after clearing private data
Nightly Fennec 15.0a1 (2012-05-02) Aurora Fennec 14.0a2 (2012-05-02) Device: HTC Desire Z OS: Android 2.3.3 Steps to reproduce: 1. Load any page (Ex. yahoo.com). 2. Clear private data from Menu>More>Settings>. 3. Go back and reload the page. Expected result: The page is reloaded. Actual result: Nothing happens when tapping the reload button.
Reproduced. -- Nightly (05/03) Samsung Galaxy Nexus (Android 4.0.4)
blocking-fennec1.0: --- → ?
Assignee: nobody → margaret.leibovic
blocking-fennec1.0: ? → +
There's no need to check for whether or not there's history when doing a reload call. The "Session:Reload" message just ends up calling browser.reload(): http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#925 Also, these methods in Tab and their corresponding methods in GeckoApp are all returning booleans, but we don't end up actually doing anything with them... Also, there seems to be a lot of redundancy there - the methods in GeckoApp all get the selected tab, then just call the corresponding method in Tab. Oh well, maybe we can fix that some other time.
Attachment #620827 - Flags: review?(mark.finkle)
This wasn't a regression.
Attachment #620827 - Flags: review?(mark.finkle) → review+
Target Milestone: --- → Firefox 15
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed on: Nightly Fennec 15.0a1 (2012-05-06) Device: HTC Desire Z OS: Android 2.3.3 Using the initial STR.
Comment on attachment 620827 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): n/a User impact if declined: reload doesn't work after clearing private data Testing completed (on m-c, etc.): landed on m-c Risk to taking this patch (and alternatives if risky): low-risk, mobile-only, just removes unnecessary check String changes made by this patch: n/a
Attachment #620827 - Flags: approval-mozilla-aurora?
Attachment #620827 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.