751488 - Can't reload the page after clearing private data

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Nightly Fennec 15.0a1 (2012-05-02)
Aurora Fennec 14.0a2 (2012-05-02)
Device: HTC Desire Z
OS: Android 2.3.3

Steps to reproduce:
1. Load any page (Ex. yahoo.com).
2. Clear private data from Menu>More>Settings>.
3. Go back and reload the page.

Expected result:
The page is reloaded.

Actual result:
Nothing happens when tapping the reload button.

Comment 1

[Aaron Train [:aaronmt]]

Reproduced.

--
Nightly (05/03)
Samsung Galaxy Nexus (Android 4.0.4)

Comment 2

[:Margaret Leibovic]

Attachment: patch

There's no need to check for whether or not there's history when doing a reload call. The "Session:Reload" message just ends up calling browser.reload():
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#925

Also, these methods in Tab and their corresponding methods in GeckoApp are all returning booleans, but we don't end up actually doing anything with them... Also, there seems to be a lot of redundancy there - the methods in GeckoApp all get the selected tab, then just call the corresponding method in Tab. Oh well, maybe we can fix that some other time.

Comment 3

[:Margaret Leibovic]

This wasn't a regression.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7094b8282d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fa7094b8282d

Comment 6

[Paul Feher]

Verified fixed on:
Nightly Fennec 15.0a1 (2012-05-06)
Device: HTC Desire Z
OS: Android 2.3.3

Using the initial STR.

Comment 7

[:Margaret Leibovic]

Comment on attachment 620827 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: reload doesn't work after clearing private data
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): low-risk, mobile-only, just removes unnecessary check
String changes made by this patch: n/a

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4de94a39aef2