Last Comment Bug 751493 - move out the nsHTMLComboboxListAccessible logic from nsHTMLSelectListAccessible::NativeRole
: move out the nsHTMLComboboxListAccessible logic from nsHTMLSelectListAccessib...
Status: RESOLVED FIXED
[good first bug][mentor=hub@mozilla.c...
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Jignesh Kakadiya [:jhk]
:
Mentors:
Depends on:
Blocks: cleana11y
  Show dependency treegraph
 
Reported: 2012-05-03 01:26 PDT by alexander :surkov
Modified: 2012-05-16 03:31 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch(v1) (2.85 KB, patch)
2012-05-08 00:21 PDT, Jignesh Kakadiya [:jhk]
surkov.alexander: feedback-
Details | Diff | Review
Patch(v2) (1.69 KB, patch)
2012-05-13 23:56 PDT, Jignesh Kakadiya [:jhk]
surkov.alexander: review-
Details | Diff | Review
Patch(v3) (2.18 KB, patch)
2012-05-14 00:20 PDT, Jignesh Kakadiya [:jhk]
surkov.alexander: review+
Details | Diff | Review

Description alexander :surkov 2012-05-03 01:26:46 PDT
just add nsHTMLComboboxListAccessible::NativeRole() and remove the related things from nsHTMLSelectListAccessible::NativeRole (http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLSelectAccessible.cpp#89)
Comment 1 Jignesh Kakadiya [:jhk] 2012-05-08 00:21:42 PDT
Created attachment 621899 [details] [diff] [review]
Patch(v1)
Comment 2 alexander :surkov 2012-05-10 20:58:28 PDT
Comment on attachment 621899 [details] [diff] [review]
Patch(v1)

Review of attachment 621899 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ -91,5 @@
> -  if (mParent && mParent->Role() == roles::COMBOBOX)
> -    return roles::COMBOBOX_LIST;
> -
> -  return roles::LISTBOX;
> -}

you should keep this method but it should return roles::LISTBOX

@@ +738,5 @@
> +{
> +  if (mParent && mParent->Role() == roles::COMBOBOX)
> +    return roles::COMBOBOX_LIST;
> +
> +  return roles::LISTBOX;

this one should return roles::COMBOBOX
Comment 3 Jignesh Kakadiya [:jhk] 2012-05-13 23:56:06 PDT
Created attachment 623598 [details] [diff] [review]
Patch(v2)
Comment 4 alexander :surkov 2012-05-13 23:58:18 PDT
Comment on attachment 623598 [details] [diff] [review]
Patch(v2)

nsHTMLSelectListAccessible can't have COMBOBOX_LIST role, so remove this part
Comment 5 Jignesh Kakadiya [:jhk] 2012-05-14 00:20:19 PDT
Created attachment 623600 [details] [diff] [review]
Patch(v3)
Comment 7 Ed Morley [:emorley] 2012-05-16 03:31:51 PDT
https://hg.mozilla.org/mozilla-central/rev/ec2594f42e9e

Note You need to log in before you can comment on or make changes to this bug.