The default bug view has changed. See this FAQ.

move out the nsHTMLComboboxListAccessible logic from nsHTMLSelectListAccessible::NativeRole

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: jhk)

Tracking

(Blocks: 1 bug)

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
just add nsHTMLComboboxListAccessible::NativeRole() and remove the related things from nsHTMLSelectListAccessible::NativeRole (http://mxr.mozilla.org/mozilla-central/source/accessible/src/html/nsHTMLSelectAccessible.cpp#89)
(Assignee)

Comment 1

5 years ago
Created attachment 621899 [details] [diff] [review]
Patch(v1)
Attachment #621899 - Flags: feedback?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 621899 [details] [diff] [review]
Patch(v1)

Review of attachment 621899 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLSelectAccessible.cpp
@@ -91,5 @@
> -  if (mParent && mParent->Role() == roles::COMBOBOX)
> -    return roles::COMBOBOX_LIST;
> -
> -  return roles::LISTBOX;
> -}

you should keep this method but it should return roles::LISTBOX

@@ +738,5 @@
> +{
> +  if (mParent && mParent->Role() == roles::COMBOBOX)
> +    return roles::COMBOBOX_LIST;
> +
> +  return roles::LISTBOX;

this one should return roles::COMBOBOX
Attachment #621899 - Flags: feedback?(surkov.alexander) → feedback-
(Assignee)

Comment 3

5 years ago
Created attachment 623598 [details] [diff] [review]
Patch(v2)
Assignee: nobody → jigneshhk1992
Attachment #621899 - Attachment is obsolete: true
Attachment #623598 - Flags: review?(surkov.alexander)
(Reporter)

Comment 4

5 years ago
Comment on attachment 623598 [details] [diff] [review]
Patch(v2)

nsHTMLSelectListAccessible can't have COMBOBOX_LIST role, so remove this part
Attachment #623598 - Flags: review?(surkov.alexander) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 623600 [details] [diff] [review]
Patch(v3)
Attachment #623598 - Attachment is obsolete: true
Attachment #623600 - Flags: review?(surkov.alexander)
(Reporter)

Updated

5 years ago
Attachment #623600 - Flags: review?(surkov.alexander) → review+
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2594f42e9e
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/ec2594f42e9e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.