Remove -fno-common flag

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla15
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
AFAICS from the CVS history, -fno-common has been there on OSX only since the 2000, when the build was made to work on OSX. I see no reason to keep it, especially considering we don't use the flag on other platforms. It also breaks my jemalloc3 queue because I rely on -fcommon to override jemalloc overridable variables (thus avoiding modifying jemalloc upstream source code and possible future merge conflicts). I could remove -fno-common when building jemalloc only, but I don't think it hurts to just remove it completely.
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 1

5 years ago
Created attachment 620635 [details] [diff] [review]
Don't use the -fno-common flag
Attachment #620635 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

5 years ago
Created attachment 620718 [details] [diff] [review]
Don't use the -fno-common flag
Attachment #620718 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

5 years ago
Attachment #620635 - Attachment is obsolete: true
Attachment #620635 - Flags: review?(ted.mielczarek)
Attachment #620718 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5854da577bcb
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/5854da577bcb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.