751529 - Optimize out nsDOMStorageItem objects from CC log by its complete removal

Status: RESOLVED DUPLICATE of bug 600307

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

whimboo got a CC log which has over 30000 nsDOMStorageItem objects.
Need to figure out how and why that happens.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

It is hard to understand who owns what objects in the storage code.
Honza, could you perhaps summarize the setup?

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to Olli Pettay [:smaug] from comment #1)
> It is hard to understand who owns what objects in the storage code.
> Honza, could you perhaps summarize the setup?

No.  And that just because I want to remove that object completely.  It is a leftover from times of the first, now obsolete, implementation of sessionStorage spec.

The object is left there just because the caching hash table is using it.  It is no longer exposed to DOM at all.  So, we can either just stop adding it to CC or rather completely remove it.

I would like to do that as part of bug 732708.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Oh, removing the class sounds good. Can we get rid of it in FF15?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: backup

I had started to write a way to optimize nsDOMStorageItems out from CC, 
but if we can get rid of those objects, event better.
I won't work more on this.

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Don't see any reason this needs to be in 15, looks like it can get fixed on whatever version is trunk at the time and then ride the trains so I am removing tracking.