Build: 2001040408, Mac OS 9.1. To reproduce: * Open a Navigator window, and go to <http://numberfinder.com/>. * Perform a search for anything. * In the window which comes up, use the `View' > `Toolbars' submenu to turn the toolbars back on. What should happen: * The items in the `View' > `Toolbars' menu should be unchecked, and checking them should turn the toolbars back on. What actually happens: * The items in the `View' > `Toolbars' menu are checked, and unchecking them and re-checking them has no effect.
The window that comes up for me doesn't have a menu bar, so I can't use the View menu to re-show the toolbar. Gerv
Doh! Of course. I see. MacOS. Yes. Right. Gerv
That means pchen, I think.
C, d'you see this?
yup, in 2001041008 builds, but I wasn't really surprised. Isn't this exactly what the author intended? It wouldn't even be possible on another platform. Maybe the 'toolbar' item should just be greyed out? regardless, reassigning to appropriate people.
I don't see what purpose disabling the items would serve, other than annoying people. The author got what he/she asked for -- a window without chrome. Now when I decide to turn the chrome on again (because it's *my* Web browser, not the Web author's), the toolbar items don't do anything. I can turn the toolbars back on in Internet Explorer, why not in Mozilla?
-> me, if Paul doesn't mind...
Sorry, I didn't realize this was Mac-only when I took it (I think I have another bug somewhere on these items not working on other platforms when the popup has a menubar). Back to Paul, but e-mail me if you're willing to send me a mac and I'll respond with my address.
I have reproduced problem. Click on side tab to "close" the tab, then go to View -> Toolbar and uncheck the item. It won't come back or show. Happens in Mail as well as browser.
->XP Apps default assignee
sorry, this was supposed to be XPApps: GUI Features
*** Bug 75742 has been marked as a duplicate of this bug. ***
Scraps: 1. <http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigator.js#1652> 2. <http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigatorOverlay.xul#167> 3. var chromehidden=document.documentElement.getAttribute("chromehidden"); var morechrome=chromehidden.replace(/\btoolbar\b/g," "); if (chromehidden!=morechrome) document.documentElement.setAttribute("chromehidden",morechrome) else do the usual thing endif
taking... i got some lines from timeless which i converted into a real fix *eg*, i will attach it as soon as my cygwin setup is finished... (or tomorrow, whichever one comes first)
Created attachment 84058 [details] [diff] [review] Proposed patch Note that this patch does not do anything about the checkmarks on the menu because they are persisted so changing them to reflect the window.open flags would impact on new windows. Nor does this patch fix the sidebar.
Created attachment 84631 [details] [diff] [review] Updated patch
Comment on attachment 84631 [details] [diff] [review] Updated patch I have talked to jst about this a while ago. We don't want to fix it this way, since it will not update the window flags it needs to. There is going to be some c++ stuff that I'll code up hopefully sometime soon that will take care of this and some other problems with window features as well.
I've been looking for a placeholder for some of this stuff. This bug will do just nicely.
*** Bug 251329 has been marked as a duplicate of this bug. ***
*** Bug 244412 has been marked as a duplicate of this bug. ***