`View' > `Show/Hide' menu items can't override window.open flags

NEW
Unassigned

Status

()

Core
DOM: Core & HTML
P3
normal
17 years ago
5 years ago

People

(Reporter: Matthew Paul Thomas, Unassigned)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p-ie/mac], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
Build: 2001040408, Mac OS 9.1.

To reproduce:
*   Open a Navigator window, and go to <http://numberfinder.com/>.
*   Perform a search for anything.
*   In the window which comes up, use the `View' > `Toolbars' submenu to turn
    the toolbars back on.

What should happen:
*   The items in the `View' > `Toolbars' menu should be unchecked, and checking
    them should turn the toolbars back on.

What actually happens:
*   The items in the `View' > `Toolbars' menu are checked, and unchecking them
    and re-checking them has no effect.
(Reporter)

Updated

17 years ago
Blocks: 26353
The window that comes up for me doesn't have a menu bar, so I can't use the 
View menu to re-show the toolbar.

Gerv
Doh! Of course. I see. MacOS. Yes. Right.

Gerv
(Reporter)

Comment 3

17 years ago
That means pchen, I think.
OS: other → Mac System 9.x
Hardware: Other → Macintosh
C, d'you see this?
QA Contact: sairuh → claudius

Comment 5

17 years ago
yup, in 2001041008 builds, but I wasn't really surprised. Isn't this exactly what the author intended?
It wouldn't even be possible on another platform. Maybe the 'toolbar' item should just be greyed out?

regardless, reassigning to appropriate people.
Assignee: ben → pinkerton
Component: XP Apps: GUI Features → XP Toolkit/Widgets: Menus
QA Contact: claudius → jrgm
-> pchen
Assignee: pinkerton → pchen
Component: XP Toolkit/Widgets: Menus → XP Apps: GUI Features
(Reporter)

Comment 7

17 years ago
I don't see what purpose disabling the items would serve, other than annoying 
people. The author got what he/she asked for -- a window without chrome. Now 
when I decide to turn the chrome on again (because it's *my* Web browser, not 
the Web author's), the toolbar items don't do anything. I can turn the toolbars 
back on in Internet Explorer, why not in Mozilla?
Whiteboard: [parity-ie/mac]

Comment 8

17 years ago
-> me, if Paul doesn't mind...
Assignee: pchen → blakeross

Comment 9

17 years ago
Sorry, I didn't realize this was Mac-only when I took it (I think I have 
another bug somewhere on these items not working on other platforms when the 
popup has a menubar).  Back to Paul, but e-mail me if you're willing to send me 
a mac and I'll respond with my address.
Assignee: blakeross → pchen
Priority: -- → P1
Target Milestone: --- → mozilla0.9.1

Updated

17 years ago
Keywords: nsbeta1-

Updated

17 years ago
Target Milestone: mozilla0.9.1 → Future

Comment 10

16 years ago
I have reproduced problem. Click on side tab to "close" the tab, then go to View
-> Toolbar and uncheck the item.  It won't come back or show. Happens in Mail as
well as browser. 
(Reporter)

Updated

16 years ago
Blocks: 103711

Comment 11

16 years ago
->default assignee
Assignee: pchen → blaker
QA Contact: jrgm → sairuh
Target Milestone: Future → ---

Comment 12

16 years ago
->XP Apps default assignee
Assignee: blaker → trudelle
Component: XP Apps: GUI Features → XP Apps

Comment 13

16 years ago
sorry, this was supposed to be XPApps: GUI Features
Assignee: trudelle → blaker
Component: XP Apps → XP Apps: GUI Features

Updated

16 years ago
Target Milestone: --- → Future

Comment 14

16 years ago
Also broken on Windows:
javascript:window.open("", "", "menubar=yes"); void 0
OS: Mac System 9.x → All
Hardware: Macintosh → All

Comment 15

16 years ago
*** Bug 75742 has been marked as a duplicate of this bug. ***
(Reporter)

Updated

16 years ago
Summary: `View' > `Toolbars' items don't work in chromeless window → `View' > `Show/Hide' menu items can't override window.open flags
Whiteboard: [parity-ie/mac] → [p-ie/mac]
(Reporter)

Comment 16

16 years ago
Scraps:

1. 
<http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigator.js#1652>
2. 
<http://lxr.mozilla.org/seamonkey/source/xpfe/browser/resources/content/navigatorOverlay.xul#167>
3.  var chromehidden=document.documentElement.getAttribute("chromehidden");
    var morechrome=chromehidden.replace(/\btoolbar\b/g," ");
    if (chromehidden!=morechrome) 
        document.documentElement.setAttribute("chromehidden",morechrome)
    else
        do the usual thing
    endif

Comment 17

16 years ago
taking... i got some lines from timeless which i converted into a real fix *eg*,
i will attach it as soon as my cygwin setup is finished... (or tomorrow,
whichever one comes first)
Assignee: blaker → rossi

Comment 18

16 years ago
Created attachment 84058 [details] [diff] [review]
Proposed patch

Note that this patch does not do anything about the checkmarks on the menu
because they are persisted so changing them to reflect the window.open flags
would impact on new windows. Nor does this patch fix the sidebar.

Updated

16 years ago

Comment 19

16 years ago
Created attachment 84631 [details] [diff] [review]
Updated patch
Attachment #84058 - Attachment is obsolete: true
Comment on attachment 84631 [details] [diff] [review]
Updated patch

I have talked to jst about this a while ago.  We don't want to fix it this way,
since it will not update the window flags it needs to.	There is going to be
some c++ stuff that I'll code up hopefully sometime soon that will take care of
this and some other problems with window features as well.
Attachment #84631 - Flags: needs-work+
I've been looking for a placeholder for some of this stuff.  This bug will do
just nicely.
Assignee: rossi → caillon
Component: XP Apps: GUI Features → DOM Level 0
Depends on: 55820, 155660
Keywords: patch, polish, review, ui
Priority: P1 → P3
QA Contact: sairuh → desale
Assignee: caillon → general
QA Contact: desale → ian

Updated

13 years ago
Blocks: 244412

Comment 22

13 years ago
*** Bug 251329 has been marked as a duplicate of this bug. ***

Updated

13 years ago
No longer blocks: 244412

Comment 23

13 years ago
*** Bug 244412 has been marked as a duplicate of this bug. ***
Assignee: general → nobody
QA Contact: ian → general
You need to log in before you can comment on or make changes to this bug.