Update opus codec to the draft-12 source

RESOLVED FIXED in mozilla15

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

unspecified
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Now that the draft-11 code as landed, update the the draft-12 version, which is the latest published version.
(Assignee)

Comment 1

5 years ago
Created attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Summary of changes:

- License header updates
- Warning fixes
- Comment improvements

Comment 2

5 years ago
Try run for b8f30171ce3d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b8f30171ce3d
Results (out of 31 total builds):
    success: 28
    warnings: 1
    other: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rgiles@mozilla.com-b8f30171ce3d
 Timed out after 12 hours without completing.
(Assignee)

Comment 3

5 years ago
Hmm, tbpl link is completely green. It doesn't say what timed out, or what the two 'other' conditions were. Win64 debug? :/

Anyway, builds and passes mochitest-1 (the media tests) everywhere I've looked.
(Assignee)

Updated

5 years ago
Attachment #620746 - Flags: review?(tterribe)
Comment on attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Review of attachment 620746 [details] [diff] [review]:
-----------------------------------------------------------------

Note that for multichannel _encoding_, we will want something from the latest git for some fixes that did not go into the draft. Decoding multichannel from the draft should be fine.
Attachment #620746 - Flags: review?(tterribe) → review+
(Assignee)

Comment 5

5 years ago
Thanks. Are we expecting any changes between draft-12 and the final RFC?

I wanted to stick with the draft text until final publication, then upgrade to the 1.0 git tag. If we need this for webrtc sooner, we can bump it.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d194ab68e16
Assignee: nobody → giles
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/1d194ab68e16
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.