Closed Bug 751607 Opened 8 years ago Closed 8 years ago

Update opus codec to the draft-12 source


(Core :: Audio/Video, defect)

Not set





(Reporter: rillian, Assigned: rillian)



(1 file)

Now that the draft-11 code as landed, update the the draft-12 version, which is the latest published version.
Summary of changes:

- License header updates
- Warning fixes
- Comment improvements
Try run for b8f30171ce3d is complete.
Detailed breakdown of the results available here:
Results (out of 31 total builds):
    success: 28
    warnings: 1
    other: 2
Builds (or logs if builds failed) available at:
 Timed out after 12 hours without completing.
Hmm, tbpl link is completely green. It doesn't say what timed out, or what the two 'other' conditions were. Win64 debug? :/

Anyway, builds and passes mochitest-1 (the media tests) everywhere I've looked.
Attachment #620746 - Flags: review?(tterribe)
Comment on attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Review of attachment 620746 [details] [diff] [review]:

Note that for multichannel _encoding_, we will want something from the latest git for some fixes that did not go into the draft. Decoding multichannel from the draft should be fine.
Attachment #620746 - Flags: review?(tterribe) → review+
Thanks. Are we expecting any changes between draft-12 and the final RFC?

I wanted to stick with the draft text until final publication, then upgrade to the 1.0 git tag. If we need this for webrtc sooner, we can bump it.
Keywords: checkin-needed
Assignee: nobody → giles
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.