Last Comment Bug 751607 - Update opus codec to the draft-12 source
: Update opus codec to the draft-12 source
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Ralph Giles (:rillian) needinfo me
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 10:01 PDT by Ralph Giles (:rillian) needinfo me
Modified: 2012-05-05 20:25 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Update to the draft-12 source (587.89 KB, patch)
2012-05-03 10:07 PDT, Ralph Giles (:rillian) needinfo me
tterribe: review+
Details | Diff | Splinter Review

Description Ralph Giles (:rillian) needinfo me 2012-05-03 10:01:20 PDT
Now that the draft-11 code as landed, update the the draft-12 version, which is the latest published version.
Comment 1 Ralph Giles (:rillian) needinfo me 2012-05-03 10:07:30 PDT
Created attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Summary of changes:

- License header updates
- Warning fixes
- Comment improvements
Comment 2 Mozilla RelEng Bot 2012-05-04 00:15:21 PDT
Try run for b8f30171ce3d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b8f30171ce3d
Results (out of 31 total builds):
    success: 28
    warnings: 1
    other: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rgiles@mozilla.com-b8f30171ce3d
 Timed out after 12 hours without completing.
Comment 3 Ralph Giles (:rillian) needinfo me 2012-05-04 08:08:16 PDT
Hmm, tbpl link is completely green. It doesn't say what timed out, or what the two 'other' conditions were. Win64 debug? :/

Anyway, builds and passes mochitest-1 (the media tests) everywhere I've looked.
Comment 4 Timothy B. Terriberry (:derf) 2012-05-04 09:16:41 PDT
Comment on attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Review of attachment 620746 [details] [diff] [review]:
-----------------------------------------------------------------

Note that for multichannel _encoding_, we will want something from the latest git for some fixes that did not go into the draft. Decoding multichannel from the draft should be fine.
Comment 5 Ralph Giles (:rillian) needinfo me 2012-05-04 10:00:25 PDT
Thanks. Are we expecting any changes between draft-12 and the final RFC?

I wanted to stick with the draft text until final publication, then upgrade to the 1.0 git tag. If we need this for webrtc sooner, we can bump it.
Comment 6 Ryan VanderMeulen [:RyanVM] 2012-05-04 19:54:35 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d194ab68e16
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-05-05 20:25:10 PDT
https://hg.mozilla.org/mozilla-central/rev/1d194ab68e16

Note You need to log in before you can comment on or make changes to this bug.