751607 - Update opus codec to the draft-12 source

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

Now that the draft-11 code as landed, update the the draft-12 version, which is the latest published version.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Update to the draft-12 source

Summary of changes:

- License header updates
- Warning fixes
- Comment improvements

Comment 2

[Mozilla RelEng Bot]

Try run for b8f30171ce3d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b8f30171ce3d
Results (out of 31 total builds):
    success: 28
    warnings: 1
    other: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-b8f30171ce3d
 Timed out after 12 hours without completing.

Comment 3

[Ralph Giles (:rillian)]

Hmm, tbpl link is completely green. It doesn't say what timed out, or what the two 'other' conditions were. Win64 debug? :/

Anyway, builds and passes mochitest-1 (the media tests) everywhere I've looked.

Comment 4

[Timothy B. Terriberry (:derf)]

Comment on attachment 620746 [details] [diff] [review]
Update to the draft-12 source

Review of attachment 620746 [details] [diff] [review]:
-----------------------------------------------------------------

Note that for multichannel _encoding_, we will want something from the latest git for some fixes that did not go into the draft. Decoding multichannel from the draft should be fine.

Comment 5

[Ralph Giles (:rillian)]

Thanks. Are we expecting any changes between draft-12 and the final RFC?

I wanted to stick with the draft text until final publication, then upgrade to the 1.0 git tag. If we need this for webrtc sooner, we can bump it.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d194ab68e16

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d194ab68e16