75164 - [tracking bug] work on |ReplaceSubstring|

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Scott Collins]

rickg's |ReplaceSubstring| has never worked and now people are starting to
complain.  This bug is to track work done to resolve this situation.

Comment 1

[Scott Collins]

Attachment: implementing |nsSubstituteC?String|, a generator that provides |ReplaceSubstring| functionality

Comment 2

[Scott Collins]

Attachment: ...oops, same as above minus changes in "nsAString.cpp" that belonged to a different bug

Comment 3

[Scott Collins]

Attachment: fixed my math in |MaxLength|, caught in review with brendan

Comment 4

[Simon Fraser [no longer active]]

+      /* mutable */ int mNumberOfMatches;
PRIn32 ?

+    int N = mNumberOfMatches;

Ditto. |N| risks collision with macros; use longer name?

+    long changePerReplacement = long(mReplacement.Length()) - 
long(mPattern.Length());

PRInt32 again?

Comment 5

[Scott Collins]

Attachment: addressing sfrasers concerns

Comment 6

[Scott Collins]

Attachment: last patch wasn't nearly as throrough at fixing sfrasers points as I intended, sorry. This one should do the trick

Comment 7

[Simon Fraser [no longer active]]

I like that one. sr=sfraser

Comment 8

[Scott Collins]

The fix to this bug is that we're going to replace the entire implementation of
|ReplaceSubstring| with the new |nsSubstituteC?String| generator (the
implementation of which was introduced right here in this bug :-).  See bug
#82456 for details of making everyone use the new machinery.