751647 - speculative connect doesnt follow spdy ip pooling

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

speculative http connections don't look up the spdy ip pooling table, so they connect to the unmapped host. This doesn't break anything because the main connection path does the right lookup, but it also isn't very useful :)

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 620792 [details] [diff] [review]
patch 0

Review of attachment 620792 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpConnectionMgr.cpp
@@ +2246,5 @@
>  
> +    // Check if there is a spdy ip pooling mapping for this host
> +    nsConnectionEntry *preferredEntry = GetSpdyPreferredEnt(ent);
> +    if (preferredEntry)
> +        ent = preferredEntry;

In other words: when you find a spdy preferred ent, it prevents creation of a new (unnecessary) connection for a host we may coalesce with an existing connection, right?  Could you please express this in some simple comment here?

Comment 3

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/404b332f7664

Comment 4

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/404b332f7664