Closed Bug 751647 Opened 8 years ago Closed 8 years ago

speculative connect doesnt follow spdy ip pooling

Categories

(Core :: Networking: HTTP, defect, minor)

15 Branch
x86_64
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: mcmanus, Assigned: mcmanus)

Details

(Whiteboard: [spdy][http-conn])

Attachments

(1 file)

speculative http connections don't look up the spdy ip pooling table, so they connect to the unmapped host. This doesn't break anything because the main connection path does the right lookup, but it also isn't very useful :)
Attached patch patch 0Splinter Review
Attachment #620792 - Flags: review?(honzab.moz)
Comment on attachment 620792 [details] [diff] [review]
patch 0

Review of attachment 620792 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpConnectionMgr.cpp
@@ +2246,5 @@
>  
> +    // Check if there is a spdy ip pooling mapping for this host
> +    nsConnectionEntry *preferredEntry = GetSpdyPreferredEnt(ent);
> +    if (preferredEntry)
> +        ent = preferredEntry;

In other words: when you find a spdy preferred ent, it prevents creation of a new (unnecessary) connection for a host we may coalesce with an existing connection, right?  Could you please express this in some simple comment here?
Attachment #620792 - Flags: review?(honzab.moz) → review+
http://hg.mozilla.org/mozilla-central/rev/404b332f7664
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [spdy] → [spdy][http-conn]
You need to log in before you can comment on or make changes to this bug.