speculative connect doesnt follow spdy ip pooling

RESOLVED FIXED in mozilla15

Status

()

Core
Networking: HTTP
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

15 Branch
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spdy][http-conn])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
speculative http connections don't look up the spdy ip pooling table, so they connect to the unmapped host. This doesn't break anything because the main connection path does the right lookup, but it also isn't very useful :)
(Assignee)

Comment 1

5 years ago
Created attachment 620792 [details] [diff] [review]
patch 0
Attachment #620792 - Flags: review?(honzab.moz)
Comment on attachment 620792 [details] [diff] [review]
patch 0

Review of attachment 620792 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpConnectionMgr.cpp
@@ +2246,5 @@
>  
> +    // Check if there is a spdy ip pooling mapping for this host
> +    nsConnectionEntry *preferredEntry = GetSpdyPreferredEnt(ent);
> +    if (preferredEntry)
> +        ent = preferredEntry;

In other words: when you find a spdy preferred ent, it prevents creation of a new (unnecessary) connection for a host we may coalesce with an existing connection, right?  Could you please express this in some simple comment here?
Attachment #620792 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/404b332f7664
http://hg.mozilla.org/mozilla-central/rev/404b332f7664
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [spdy] → [spdy][http-conn]
You need to log in before you can comment on or make changes to this bug.