bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

ship python requirements with socorro

RESOLVED FIXED in 9

Status

Socorro
Infra
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

(Assignee)

Description

6 years ago
lonnen and I were just discussing on IRC how painful it is to maintain our Python libraries as RPM, especially with a distro like RHEL this means we need to spend a lot of time building RPMs from pypi and giving them to IT, and blocking releases on these type of out-of-band activities. It's painful enough that we don't really keep things up to date.

Instead I propose we have the Makefile do:

1) pip install -r requirements.txt -> socorro-virtualenv
2) copy socorro-virtualenv/(...)/site-packages/ -> /data/socorro/thirdparty/

This means that things will Just Work when you add a dependency to requirements.txt, in all environments (local, vagrant, jenkins, dev/stage/prod).

Jenkins will build the socorro.tar.gz with these baked on, so IT doesn't need to worry about running pip and having it pollute the system Python dir (and having to track that etc)
(Assignee)

Comment 1

6 years ago
r? https://github.com/mozilla/socorro/pull/553
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED

Comment 2

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/61810a2714a5257d43171a9bfbe59eafc43d6ca1
bug 751654 - ship site-packages from virtualenv in thirdparty dir

https://github.com/mozilla/socorro/commit/970eae86bd52d4e36bcc17ce44db5553bbda5209
Merge pull request #553 from rhelmer/bug751654-ship-requirements

bug 751654 - ship site-packages from virtualenv in thirdparty dir
(Assignee)

Comment 3

6 years ago
r? https://github.com/mozilla/socorro/pull/562

After discussing w/ peterbe:

* use requirements instead of submodule for configman
* pin versions in requirements.txt
* remove everything in thirdparty/ use requirements only
Target Milestone: --- → 9

Comment 4

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/a2933c481f413df8860a138a854d8b8dff22f5a9
bug 751654 - pin versions and manage thirdparty with requirements.txt only

https://github.com/mozilla/socorro/commit/e84658dcc2881b9ad23bda67ed519953640f1686
Merge pull request #562 from rhelmer/bug751654-cleanup-reqs

bug 751654 - pin versions and manage thirdparty with requirements.txt on...

Comment 5

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5c55a4900b02e72e6807ec09000445d4af656340
bug 751654 - make psycopg2 work for RHEL6 with postgres 9.0 RPM

https://github.com/mozilla/socorro/commit/b3b6e0f6f11d66ab7bd377f69455111a4639a264
Merge pull request #565 from rhelmer/master

bug 751654 - make psycopg2 work for RHEL6 with postgres 9.0 RPM

Comment 8

6 years ago
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/380c00efa754f47167d89b21c59b3902ad90bde7
bug 751654 - setupdb needs thirdparty on PYTHONPATH now that we do not expect the system to provide it

https://github.com/mozilla/socorro/commit/e3961922ae147284c62f50a7e22776855c64925e
Merge pull request #568 from rhelmer/master

bug 751654 - setupdb needs thirdparty on PYTHONPATH
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [qa?]
(Assignee)

Comment 10

6 years ago
This is mostly qa-, although we'll want to double-check that all the usual things work (generate a crash and send it in, make sure a report is available for it shortly thereafter)
Thanks rhelmer - I'll bump this to [qa-] then. Our automaton and integration tests should provide the appropriate coverage.
Whiteboard: [qa?] → [qa-]
(Assignee)

Updated

6 years ago
Blocks: 753616
You need to log in before you can comment on or make changes to this bug.