Comment 1 :Ehsan Akhgari 2012-05-03 13:05:50 PDT

Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

Review of attachment 620807 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I know nothing about this...

Comment 2 Joe Drew (not getting mail) 2012-05-03 13:23:43 PDT

Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

This is totally safe, considering it's just an optimization, but it sure doesn't make me happy.

Don't forget to add it as a cairo patch.

Comment 3 Jeff Muizelaar [:jrmuizel] 2012-05-03 22:10:57 PDT

https://hg.mozilla.org/integration/mozilla-inbound/rev/f561a638fe1e

Comment 4 Jeff Muizelaar [:jrmuizel] 2012-05-04 10:36:12 PDT

Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: black edges on images
Testing completed (on m-c, etc.): locally and on inbound
Risk to taking this patch (and alternatives if risky): Possible performance regression, but very unlikely. If there is a performance regression, it is likely to only effect mobile.
String changes made by this patch: none

Comment 5 Ed Morley [:emorley] 2012-05-04 11:41:03 PDT

https://hg.mozilla.org/mozilla-central/rev/f561a638fe1e

Comment 6 Brad Lassey [:blassey] (use needinfo?) 2012-05-06 20:06:36 PDT

(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 620807 [details] [diff] [review]
> Avoid incorrectly using EXTEND_NONE
> 
> [Approval Request Comment]
> Regression caused by (bug #): none
> User impact if declined: black edges on images
> Testing completed (on m-c, etc.): locally and on inbound
> Risk to taking this patch (and alternatives if risky): Possible performance
> regression, but very unlikely. If there is a performance regression, it is
> likely to only effect mobile.
> String changes made by this patch: none

let's let this bake on trunk for a couple nightlies

Comment 7 JP Rosevear [:jpr] 2012-05-07 08:01:07 PDT

Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

Baked on on central, giving approval.

Comment 8 JP Rosevear [:jpr] 2012-05-07 08:01:40 PDT

Backfilling beta+ so its on our radar.

Comment 9 Jeff Muizelaar [:jrmuizel] 2012-05-07 14:25:42 PDT

https://hg.mozilla.org/releases/mozilla-aurora/rev/e73465a6bfcb

Comment 10 JP Rosevear [:jpr] 2012-05-08 07:57:45 PDT

Aurora is actually 14.