Closed Bug 751668 Opened 13 years ago Closed 13 years ago

Avoid incorrectly using EXTEND_NONE

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox14 --- fixed
blocking-fennec1.0 --- beta+

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

It seems like we sometimes end up using EXTEND_NONE unintentionally, this is likely caused by different rounding between cairo and pixman. Pixman already does a similar reduction to EXTEND_NONE so there's not point in duplicating it here.
Attachment #620807 - Flags: review?(ehsan)
Blocks: 750598
Comment on attachment 620807 [details] [diff] [review] Avoid incorrectly using EXTEND_NONE Review of attachment 620807 [details] [diff] [review]: ----------------------------------------------------------------- Sorry, I know nothing about this...
Attachment #620807 - Flags: review?(ehsan) → review?(joe)
Assignee: nobody → jmuizelaar
Comment on attachment 620807 [details] [diff] [review] Avoid incorrectly using EXTEND_NONE This is totally safe, considering it's just an optimization, but it sure doesn't make me happy. Don't forget to add it as a cairo patch.
Attachment #620807 - Flags: review?(joe) → review+
Target Milestone: mozilla14 → mozilla15
Comment on attachment 620807 [details] [diff] [review] Avoid incorrectly using EXTEND_NONE [Approval Request Comment] Regression caused by (bug #): none User impact if declined: black edges on images Testing completed (on m-c, etc.): locally and on inbound Risk to taking this patch (and alternatives if risky): Possible performance regression, but very unlikely. If there is a performance regression, it is likely to only effect mobile. String changes made by this patch: none
Attachment #620807 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
blocking-fennec1.0: --- → ?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4) > Comment on attachment 620807 [details] [diff] [review] > Avoid incorrectly using EXTEND_NONE > > [Approval Request Comment] > Regression caused by (bug #): none > User impact if declined: black edges on images > Testing completed (on m-c, etc.): locally and on inbound > Risk to taking this patch (and alternatives if risky): Possible performance > regression, but very unlikely. If there is a performance regression, it is > likely to only effect mobile. > String changes made by this patch: none let's let this bake on trunk for a couple nightlies
Comment on attachment 620807 [details] [diff] [review] Avoid incorrectly using EXTEND_NONE Baked on on central, giving approval.
Attachment #620807 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backfilling beta+ so its on our radar.
blocking-fennec1.0: ? → beta+
Aurora is actually 14.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: