Closed
Bug 751668
Opened 13 years ago
Closed 13 years ago
Avoid incorrectly using EXTEND_NONE
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
720 bytes,
patch
|
joe
:
review+
jpr
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It seems like we sometimes end up using EXTEND_NONE unintentionally, this is likely caused by different rounding between cairo and pixman. Pixman already does a similar reduction to EXTEND_NONE so there's not point in duplicating it here.
Attachment #620807 -
Flags: review?(ehsan)
Comment 1•13 years ago
|
||
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE
Review of attachment 620807 [details] [diff] [review]:
-----------------------------------------------------------------
Sorry, I know nothing about this...
Attachment #620807 -
Flags: review?(ehsan) → review?(joe)
Updated•13 years ago
|
Assignee: nobody → jmuizelaar
Comment 2•13 years ago
|
||
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE
This is totally safe, considering it's just an optimization, but it sure doesn't make me happy.
Don't forget to add it as a cairo patch.
Attachment #620807 -
Flags: review?(joe) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla14
Assignee | ||
Updated•13 years ago
|
Target Milestone: mozilla14 → mozilla15
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE
[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: black edges on images
Testing completed (on m-c, etc.): locally and on inbound
Risk to taking this patch (and alternatives if risky): Possible performance regression, but very unlikely. If there is a performance regression, it is likely to only effect mobile.
String changes made by this patch: none
Attachment #620807 -
Flags: approval-mozilla-aurora?
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
blocking-fennec1.0: --- → ?
Comment 6•13 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 620807 [details] [diff] [review]
> Avoid incorrectly using EXTEND_NONE
>
> [Approval Request Comment]
> Regression caused by (bug #): none
> User impact if declined: black edges on images
> Testing completed (on m-c, etc.): locally and on inbound
> Risk to taking this patch (and alternatives if risky): Possible performance
> regression, but very unlikely. If there is a performance regression, it is
> likely to only effect mobile.
> String changes made by this patch: none
let's let this bake on trunk for a couple nightlies
Comment 7•13 years ago
|
||
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE
Baked on on central, giving approval.
Attachment #620807 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•13 years ago
|
||
status-firefox15:
--- → fixed
Comment 10•13 years ago
|
||
Aurora is actually 14.
status-firefox14:
--- → fixed
status-firefox15:
fixed → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•