Avoid incorrectly using EXTEND_NONE

RESOLVED FIXED in Firefox 14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox14 fixed, blocking-fennec1.0 beta+)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

It seems like we sometimes end up using EXTEND_NONE unintentionally, this is likely caused by different rounding between cairo and pixman. Pixman already does a similar reduction to EXTEND_NONE so there's not point in duplicating it here.
Attachment #620807 - Flags: review?(ehsan)
(Assignee)

Updated

5 years ago
Blocks: 750598
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

Review of attachment 620807 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I know nothing about this...
Attachment #620807 - Flags: review?(ehsan) → review?(joe)
Assignee: nobody → jmuizelaar
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

This is totally safe, considering it's just an optimization, but it sure doesn't make me happy.

Don't forget to add it as a cairo patch.
Attachment #620807 - Flags: review?(joe) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/f561a638fe1e
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Target Milestone: mozilla14 → mozilla15
(Assignee)

Comment 4

5 years ago
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: black edges on images
Testing completed (on m-c, etc.): locally and on inbound
Risk to taking this patch (and alternatives if risky): Possible performance regression, but very unlikely. If there is a performance regression, it is likely to only effect mobile.
String changes made by this patch: none
Attachment #620807 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f561a638fe1e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
blocking-fennec1.0: --- → ?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #4)
> Comment on attachment 620807 [details] [diff] [review]
> Avoid incorrectly using EXTEND_NONE
> 
> [Approval Request Comment]
> Regression caused by (bug #): none
> User impact if declined: black edges on images
> Testing completed (on m-c, etc.): locally and on inbound
> Risk to taking this patch (and alternatives if risky): Possible performance
> regression, but very unlikely. If there is a performance regression, it is
> likely to only effect mobile.
> String changes made by this patch: none

let's let this bake on trunk for a couple nightlies

Comment 7

5 years ago
Comment on attachment 620807 [details] [diff] [review]
Avoid incorrectly using EXTEND_NONE

Baked on on central, giving approval.
Attachment #620807 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

5 years ago
Backfilling beta+ so its on our radar.
blocking-fennec1.0: ? → beta+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/e73465a6bfcb
status-firefox15: --- → fixed

Comment 10

5 years ago
Aurora is actually 14.
status-firefox14: --- → fixed
status-firefox15: fixed → ---
You need to log in before you can comment on or make changes to this bug.