Fix usage of nsIAlertsService in nsBrowserGlue

RESOLVED FIXED in Firefox 15

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zpao, Unassigned)

Tracking

Trunk
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 620855 [details] [diff] [review]
Patch v0.1

The first parameter is supposed to be an image url, which we don't need. The name parameter should almost never be used (as far as I can tell). And with Growl, only whitelisted alert names can be shown. Null names fallback to "General Notification" which is whitelisted by default. So if we actually pass the name we thought we were passing, then the notification won't show.
Attachment #620855 - Flags: review?(gavin.sharp)
Attachment #620855 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/fx-team/rev/e2d869fb7131
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/e2d869fb7131
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in before you can comment on or make changes to this bug.