Last Comment Bug 751711 - Fix usage of nsIAlertsService in nsBrowserGlue
: Fix usage of nsIAlertsService in nsBrowserGlue
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 15
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 14:26 PDT by Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
Modified: 2012-05-04 15:38 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v0.1 (906 bytes, patch)
2012-05-03 14:26 PDT, Paul O'Shannessy [:zpao] (not reading much bugmail, email directly)
gavin.sharp: review+
Details | Diff | Review

Description Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-05-03 14:26:23 PDT
Created attachment 620855 [details] [diff] [review]
Patch v0.1

The first parameter is supposed to be an image url, which we don't need. The name parameter should almost never be used (as far as I can tell). And with Growl, only whitelisted alert names can be shown. Null names fallback to "General Notification" which is whitelisted by default. So if we actually pass the name we thought we were passing, then the notification won't show.
Comment 1 Paul O'Shannessy [:zpao] (not reading much bugmail, email directly) 2012-05-04 11:35:02 PDT
https://hg.mozilla.org/integration/fx-team/rev/e2d869fb7131
Comment 2 Tim Taubert [:ttaubert] 2012-05-04 15:38:59 PDT
https://hg.mozilla.org/mozilla-central/rev/e2d869fb7131

Note You need to log in before you can comment on or make changes to this bug.