Closed
Bug 751711
Opened 13 years ago
Closed 13 years ago
Fix usage of nsIAlertsService in nsBrowserGlue
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 15
People
(Reporter: zpao, Unassigned)
Details
Attachments
(1 file)
|
906 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
The first parameter is supposed to be an image url, which we don't need. The name parameter should almost never be used (as far as I can tell). And with Growl, only whitelisted alert names can be shown. Null names fallback to "General Notification" which is whitelisted by default. So if we actually pass the name we thought we were passing, then the notification won't show.
Attachment #620855 -
Flags: review?(gavin.sharp)
|
||
Updated•13 years ago
|
Attachment #620855 -
Flags: review?(gavin.sharp) → review+
|
Reporter | |
Comment 1•13 years ago
|
||
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 15
|
||
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
You need to log in
before you can comment on or make changes to this bug.
Description
•