Last Comment Bug 751779 - Support leaf addresses on mac/win with speudostack
: Support leaf addresses on mac/win with speudostack
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla15
Assigned To: Benoit Girard (:BenWa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-03 17:10 PDT by Benoit Girard (:BenWa)
Modified: 2012-05-05 03:39 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.34 KB, patch)
2012-05-03 17:10 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Splinter Review
Sample screenshot (nicer trace) (118.57 KB, image/png)
2012-05-03 17:15 PDT, Benoit Girard (:BenWa)
no flags Details
win version (608 bytes, patch)
2012-05-04 10:21 PDT, Benoit Girard (:BenWa)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-05-03 17:10:37 PDT
Created attachment 620903 [details] [diff] [review]
patch

The pre-req was added with platform-mac.cc by properly setting the pc but was never enabled.

Makes profiling release builds nicer.
Comment 1 Benoit Girard (:BenWa) 2012-05-03 17:15:51 PDT
Created attachment 620905 [details]
Sample screenshot (nicer trace)
Comment 2 Benoit Girard (:BenWa) 2012-05-03 18:25:01 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c

We should be able to do the same on windows but I not handy for me to test the patch ATM.
Comment 3 Benoit Girard (:BenWa) 2012-05-04 10:21:12 PDT
Created attachment 621090 [details] [diff] [review]
win version

We tested on windows and this also work. I'll do this on linux when I have time to test it.
Comment 4 Ed Morley [:emorley] 2012-05-04 11:41:47 PDT
(In reply to Benoit Girard (:BenWa) from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c
> 
> We should be able to do the same on windows but I not handy for me to test
> the patch ATM.

https://hg.mozilla.org/mozilla-central/rev/a4c02dde700c
Comment 6 Ed Morley [:emorley] 2012-05-05 03:39:51 PDT
https://hg.mozilla.org/mozilla-central/rev/aa59a28665b0

Note You need to log in before you can comment on or make changes to this bug.