The default bug view has changed. See this FAQ.

Support leaf addresses on mac/win with speudostack

RESOLVED FIXED in mozilla15

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla15
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 620903 [details] [diff] [review]
patch

The pre-req was added with platform-mac.cc by properly setting the pc but was never enabled.

Makes profiling release builds nicer.
Attachment #620903 - Flags: review?(jmuizelaar)
(Assignee)

Comment 1

5 years ago
Created attachment 620905 [details]
Sample screenshot (nicer trace)
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #620903 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c

We should be able to do the same on windows but I not handy for me to test the patch ATM.
(Assignee)

Comment 3

5 years ago
Created attachment 621090 [details] [diff] [review]
win version

We tested on windows and this also work. I'll do this on linux when I have time to test it.
Attachment #621090 - Flags: review?(jmuizelaar)
(In reply to Benoit Girard (:BenWa) from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c
> 
> We should be able to do the same on windows but I not handy for me to test
> the patch ATM.

https://hg.mozilla.org/mozilla-central/rev/a4c02dde700c
Target Milestone: --- → mozilla15
Attachment #621090 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa59a28665b0
Summary: Support leaf addresses on mac with speudostack → Support leaf addresses on mac/win with speudostack
https://hg.mozilla.org/mozilla-central/rev/aa59a28665b0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.