Closed
Bug 751779
Opened 14 years ago
Closed 14 years ago
Support leaf addresses on mac/win with speudostack
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: BenWa, Assigned: BenWa)
Details
Attachments
(3 files)
|
1.34 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
118.57 KB,
image/png
|
Details | |
|
608 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
Sample screenshot (nicer trace)
The pre-req was added with platform-mac.cc by properly setting the pc but was never enabled.
Makes profiling release builds nicer.
Attachment #620903 -
Flags: review?(jmuizelaar)
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
|
||
Updated•14 years ago
|
Attachment #620903 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c
We should be able to do the same on windows but I not handy for me to test the patch ATM.
|
|
Assignee | |
Comment 3•14 years ago
|
||
We tested on windows and this also work. I'll do this on linux when I have time to test it.
Attachment #621090 -
Flags: review?(jmuizelaar)
|
||
Comment 4•14 years ago
|
||
(In reply to Benoit Girard (:BenWa) from comment #2)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c02dde700c
>
> We should be able to do the same on windows but I not handy for me to test
> the patch ATM.
https://hg.mozilla.org/mozilla-central/rev/a4c02dde700c
Target Milestone: --- → mozilla15
|
|
||
Updated•14 years ago
|
Attachment #621090 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
Summary: Support leaf addresses on mac with speudostack → Support leaf addresses on mac/win with speudostack
|
|
||
Comment 6•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•