Closed Bug 751797 Opened 8 years ago Closed 8 years ago

crash printing due to font inflation

Categories

(Core :: Layout, defect)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla15
Tracking Status
firefox14 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: crash, Whiteboard: [readability])

Attachments

(2 files)

Attached patch patchSplinter Review
I hit a crash printing in a debug build due to font inflation code.  This crash would also affect builds with font inflation enabled and affect other sorts of pagination (e.g., multicol).  (There's some font inflation code that I intentionally run in debug builds even when font inflation is disabled, so that we see the assertions.)

In any case, this patch fixes it; it's one place I missed maintaining the invariant that this function operates only on first-in-flows.
Attachment #620934 - Flags: review?(roc)
Blocks: 750202
Severity: normal → critical
Attached patch patch 2Splinter Review
Crashed again; turns out I missed another one.  Hopefully this is really the last one, though.
Attachment #621050 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/33168c4c4703
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 620934 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 706193
User impact if declined: crash
Testing completed (on m-c, etc.): on mozilla-central for a bit
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none
Attachment #620934 - Flags: approval-mozilla-aurora?
Comment on attachment 621050 [details] [diff] [review]
patch 2

[Approval Request Comment]
Regression caused by (bug #): bug 706193
User impact if declined: crash
Testing completed (on m-c, etc.): on mozilla-central for a bit
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none
Attachment #621050 - Flags: approval-mozilla-aurora?
blocking-fennec1.0: --- → ?
blocking-fennec1.0: ? → +
Attachment #620934 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #621050 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.