Closed
Bug 751845
Opened 13 years ago
Closed 13 years ago
Cleanup after bug 691898
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
371.62 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Bug 691898 removed the use of pcre, we can thus remove the pcre source, and clean up the Makefile a bit.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #620999 -
Flags: review?(dmandelin)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: general → mh+mozilla
|
||
Comment 2•13 years ago
|
||
Maybe dumb, but shouldnt the '# BEGIN include sources for the Nitro assembler' comment move below too (well, just before the ifneq on yarr jit archs) ? Or "Nitro" has nothing to do with YARR JIT ?
|
||
Comment 3•13 years ago
|
||
\o/
|
||
Comment 4•13 years ago
|
||
Comment on attachment 620999 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Review of attachment 620999 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/Makefile.in
@@ +334,3 @@
> PageBlock.cpp \
> YarrInterpreter.cpp \
> YarrJIT.cpp \
I probably wouldn't have noticed this but for Landry's comment, but shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to David Mandelin from comment #4)
> I probably wouldn't have noticed this but for Landry's comment, but
> shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?
You're right
|
|
Assignee | |
Comment 6•13 years ago
|
||
Attachment #621261 -
Flags: review?(dmandelin)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #620999 -
Attachment is obsolete: true
Attachment #620999 -
Flags: review?(dmandelin)
|
|
||
Comment 7•13 years ago
|
||
Comment on attachment 621261 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Review of attachment 621261 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for cleaning this up. And thanks for fixing up the Makefile a bit while you were at it.
Attachment #621261 -
Flags: review?(dmandelin) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Target Milestone: --- → mozilla15
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•