Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Bug 691898 removed the use of pcre, we can thus remove the pcre source, and clean up the Makefile a bit.
(Assignee)

Comment 1

5 years ago
Created attachment 620999 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Attachment #620999 - Flags: review?(dmandelin)
(Assignee)

Updated

5 years ago
Assignee: general → mh+mozilla
Maybe dumb, but shouldnt the  '# BEGIN include sources for the Nitro assembler' comment move below too (well, just before the ifneq on yarr jit archs) ? Or "Nitro" has nothing to do with YARR JIT ?

Comment 3

5 years ago
\o/
Comment on attachment 620999 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898

Review of attachment 620999 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +334,3 @@
>  		PageBlock.cpp \
>  		YarrInterpreter.cpp \
>  		YarrJIT.cpp \

I probably wouldn't have noticed this but for Landry's comment, but shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?
Blocks: 731110
(Assignee)

Comment 5

5 years ago
(In reply to David Mandelin from comment #4)
> I probably wouldn't have noticed this but for Landry's comment, but
> shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?

You're right
(Assignee)

Comment 6

5 years ago
Created attachment 621261 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Attachment #621261 - Flags: review?(dmandelin)
(Assignee)

Updated

5 years ago
Attachment #620999 - Attachment is obsolete: true
Attachment #620999 - Flags: review?(dmandelin)
Comment on attachment 621261 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898

Review of attachment 621261 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up. And thanks for fixing up the Makefile a bit while you were at it.
Attachment #621261 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d08ec173f49b
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/d08ec173f49b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.