Last Comment Bug 751845 - Cleanup after bug 691898
: Cleanup after bug 691898
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mike Hommey [:glandium]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on: 691898
Blocks: 731110
  Show dependency treegraph
 
Reported: 2012-05-04 03:16 PDT by Mike Hommey [:glandium]
Modified: 2012-05-10 18:44 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898 (371.57 KB, patch)
2012-05-04 03:18 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898 (371.62 KB, patch)
2012-05-05 00:22 PDT, Mike Hommey [:glandium]
dmandelin: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2012-05-04 03:16:26 PDT
Bug 691898 removed the use of pcre, we can thus remove the pcre source, and clean up the Makefile a bit.
Comment 1 Mike Hommey [:glandium] 2012-05-04 03:18:03 PDT
Created attachment 620999 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Comment 2 Landry Breuil (:gaston) 2012-05-04 04:07:42 PDT
Maybe dumb, but shouldnt the  '# BEGIN include sources for the Nitro assembler' comment move below too (well, just before the ifneq on yarr jit archs) ? Or "Nitro" has nothing to do with YARR JIT ?
Comment 3 Luke Wagner [:luke] 2012-05-04 09:47:10 PDT
\o/
Comment 4 David Mandelin [:dmandelin] 2012-05-04 16:22:13 PDT
Comment on attachment 620999 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898

Review of attachment 620999 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/Makefile.in
@@ +334,3 @@
>  		PageBlock.cpp \
>  		YarrInterpreter.cpp \
>  		YarrJIT.cpp \

I probably wouldn't have noticed this but for Landry's comment, but shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?
Comment 5 Mike Hommey [:glandium] 2012-05-05 00:21:11 PDT
(In reply to David Mandelin from comment #4)
> I probably wouldn't have noticed this but for Landry's comment, but
> shouldn't YarrJIT.cpp be included only if ENABLE_YARR_JIT=1?

You're right
Comment 6 Mike Hommey [:glandium] 2012-05-05 00:22:44 PDT
Created attachment 621261 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898
Comment 7 David Mandelin [:dmandelin] 2012-05-07 12:45:14 PDT
Comment on attachment 621261 [details] [diff] [review]
Remove pcre source, and cleanup js/src/Makefile.in after bug 691898

Review of attachment 621261 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning this up. And thanks for fixing up the Makefile a bit while you were at it.
Comment 9 Joe Drew (not getting mail) 2012-05-10 18:44:47 PDT
https://hg.mozilla.org/mozilla-central/rev/d08ec173f49b

Note You need to log in before you can comment on or make changes to this bug.