75188 - mailEditorOverlay.dtd redundant?

Status: NEW

(SeaMonkey :: Composer, defect)

Description

[Håkan Waara]

contents of mailEditorOverlay.dtd:
----
<!ENTITY sendPage.label                   "Send Page...">
<!ENTITY sendPage.accesskey               "g"
----

contents of mailNavigatorOverlay.dtd:
----
<!-- File->New->Message -->
<!ENTITY  newMessageCmd.label             "Message">
<!ENTITY  newMessageCmd.accesskey         "m">

<!ENTITY sendPage.label                   "Send Page...">
<!ENTITY sendPage.accesskey               "g">

<!ENTITY sendLinkCmd.label                "Send Link..."> 
<!ENTITY sendLinkCmd.accesskey            "i">
----

As you can see, sendPage.* is defined in both of these files with the exception
that mailNavigatorOverlay.dtd includes other locales as well.

I suggest that we remove mailEditorOverlay.dtd and include
mailNavigatorOverlay.dtd in whatever XUL files the former is used.

Comments?

Comment 1

[Håkan Waara]

CC brade. Does this have anything to do with the relationship mailnews <-> editor?

Comment 2

[timeless]

smaller files cost less for loads. *shrug*

Comment 3

[Kathleen :Brade]

only mailEditorOverlay.xul appears to use that dtd file.
I'm not sure what the real gain is by changing around the dtd files.  If someone 
were to remove mailEditorOverlay.dtd and replace it with 
mailNavigatorOverlay.dtd, mailNavigatorOverlay.dtd should be renamed so that it 
doesn't seem so directly and solely related mailNavigatorOverlay.xul.

My vote is to leave this as is (wontfix) but others may have better input.

Comment 4

[Charles Manske]

I would agree it is better to use just one DTD file, and I also agree the name
should be changed. I would propose something like "mailFileMenuOverlay.dtd",
since in both Nav. and Composer (and other possible users?), that's its main
purpose. In fact, we should be using it for the "Send Link" menuitem now, it
is missing from Composer's File menu.
Any of this should wait for next release, so I suggest setting to 1.0 or
later milestone.

Comment 5

[:aceman]

This seems to apply only to Seamonkey today.