Closed Bug 751896 Opened 8 years ago Closed 8 years ago

BasicTiledThebesLayer should use OPERATOR_SOURCE

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14
Tracking Status
firefox14 --- fixed
firefox15 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: BenWa, Assigned: BenWa)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #621055 - Flags: review?(jmuizelaar)
Low risk perf win, suggesting tracking+uplift.
tracking-fennec: --- → ?
Attachment #621055 - Flags: review?(jmuizelaar) → review+
Comment on attachment 621055 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): Not a regression
User impact if declined: Useless fill affecting peformance
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very small
String changes made by this patch: none
Attachment #621055 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/c41d847fb36e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
blocking-fennec1.0: --- → ?
(In reply to Benoit Girard (:BenWa) from comment #4)
> Comment on attachment 621055 [details] [diff] [review]
> patch
> 
> [Approval Request Comment]
> Regression caused by (bug #): Not a regression
> User impact if declined: Useless fill affecting peformance
> Testing completed (on m-c, etc.): landed on m-c
> Risk to taking this patch (and alternatives if risky): very small
> String changes made by this patch: none

let's let this bake on trunk for a couple nightlies before uplifting
We are leaving all non-beta+ bugs nominated for Aurora approval in the queue until FN14 Beta 1 is signed off on by QA.
Comment on attachment 621055 [details] [diff] [review]
patch

[Triage Comment]
Broken WebGL apps, and we're very early in the cycle. Approving for Aurora 14.
Attachment #621055 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
tracking-fennec: ? → ---
blocking-fennec1.0: ? → +
Benoit, can you land this on Aurora?
(In reply to Alex Keybl [:akeybl] from comment #8)
> Comment on attachment 621055 [details] [diff] [review]
> patch
> 
> [Triage Comment]
> Broken WebGL apps, and we're very early in the cycle. Approving for Aurora
> 14.

This wont impact WebGL. This just give us a bit better performance.

(In reply to Joe Drew (:JOEDREW!) from comment #9)
> Benoit, can you land this on Aurora?

landing now
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.