751896 - BasicTiledThebesLayer should use OPERATOR_SOURCE

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 2

[Benoit Girard (:BenWa)]

Low risk perf win, suggesting tracking+uplift.

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c41d847fb36e

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 621055 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): Not a regression
User impact if declined: Useless fill affecting peformance
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): very small
String changes made by this patch: none

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c41d847fb36e

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Benoit Girard (:BenWa) from comment #4)
> Comment on attachment 621055 [details] [diff] [review]
> patch
> 
> [Approval Request Comment]
> Regression caused by (bug #): Not a regression
> User impact if declined: Useless fill affecting peformance
> Testing completed (on m-c, etc.): landed on m-c
> Risk to taking this patch (and alternatives if risky): very small
> String changes made by this patch: none

let's let this bake on trunk for a couple nightlies before uplifting

Comment 7

[Alex Keybl [:akeybl]]

We are leaving all non-beta+ bugs nominated for Aurora approval in the queue until FN14 Beta 1 is signed off on by QA.

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 621055 [details] [diff] [review]
patch

[Triage Comment]
Broken WebGL apps, and we're very early in the cycle. Approving for Aurora 14.

Comment 9

[Joe Drew (not getting mail)]

Benoit, can you land this on Aurora?

Comment 10

[Benoit Girard (:BenWa)]

(In reply to Alex Keybl [:akeybl] from comment #8)
> Comment on attachment 621055 [details] [diff] [review]
> patch
> 
> [Triage Comment]
> Broken WebGL apps, and we're very early in the cycle. Approving for Aurora
> 14.

This wont impact WebGL. This just give us a bit better performance.

(In reply to Joe Drew (:JOEDREW!) from comment #9)
> Benoit, can you land this on Aurora?

landing now

Comment 11

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e381efd3d9c5