Last Comment Bug 751924 - JS strict warnings in gGestureSupport code because functions don't always return a value
: JS strict warnings in gGestureSupport code because functions don't always ret...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 15
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-04 09:39 PDT by Dão Gottwald [:dao]
Modified: 2013-11-12 00:57 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.25 KB, patch)
2012-05-04 09:39 PDT, Dão Gottwald [:dao]
fryn: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-05-04 09:39:02 PDT
Created attachment 621074 [details] [diff] [review]
patch

JavaScript strict warning: chrome://browser/content/browser.js, line 4658: function GS_handleEvent does not always return a value
JavaScript strict warning: chrome://browser/content/browser.js, line 4630: function GS_handleEvent does not always return a value
JavaScript strict warning: chrome://browser/content/browser.js, line 4805: anonymous function does not always return a value

Also, _doAction always returns a value, but it's never looked at.
Comment 1 Frank Yan (:fryn) 2012-05-04 11:27:37 PDT
Comment on attachment 621074 [details] [diff] [review]
patch

Thanks for converting the inefficient forEach.
Comment 3 Ed Morley [:emorley] 2012-05-05 03:42:19 PDT
https://hg.mozilla.org/mozilla-central/rev/341e99692944

Note You need to log in before you can comment on or make changes to this bug.