Last Comment Bug 751929 - Crash when Alt+Space (inbound hourly crashes but not inbound nightly same change-set)
: Crash when Alt+Space (inbound hourly crashes but not inbound nightly same cha...
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Widget: Win32 (show other bugs)
: 15 Branch
: x86 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
Mentors:
Depends on:
Blocks: 166240
  Show dependency treegraph
 
Reported: 2012-05-04 09:58 PDT by Alice0775 White
Modified: 2012-05-04 15:49 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (893 bytes, patch)
2012-05-04 10:41 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
jmathies: review+
Details | Diff | Review

Description Alice0775 White 2012-05-04 09:58:55 PDT
Build Identifier:
Inbound hourly build
http://hg.mozilla.org/integration/mozilla-inbound/rev/5854da577bcb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120504005049
Inbound nightly build
http://hg.mozilla.org/integration/mozilla-inbound/rev/5854da577bcb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120504040218

Crash when Alt+Space in inbound hourly
Strange thing: inbound hourly crashes but not inbound nightly same change-set

Reproducible: Always

Steps to Reproduce:
1. Alt+Space

Actual results:
  Crash

Expected results:
  Not crash.
  Window control menu pops up.


Regression window:
Works:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a6a335cd2c94
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120503010011
Fails:
http://hg.mozilla.org/integration/mozilla-inbound/rev/de5745bce8bc
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120503013602
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a6a335cd2c94&tochange=de5745bce8bc

Regressed by: Bug 166240
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-05-04 10:25:46 PDT
Oh, this is an idiot mistake... not crashed, it aborts itself...
Comment 2 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-05-04 10:41:22 PDT
Created attachment 621099 [details] [diff] [review]
Patch

Just inserting "break" at the end of case WM_*CHAR in NativeKey.
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) 2012-05-04 15:49:54 PDT
https://hg.mozilla.org/mozilla-central/rev/6d6e9cc558f0

Note You need to log in before you can comment on or make changes to this bug.