Closed Bug 751930 Opened 8 years ago Closed 8 years ago

Don't request write/read stock Android browser history and bookmarks

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 15
Tracking Status
firefox14 --- fixed
blocking-fennec1.0 --- beta+

People

(Reporter: kbrosnan, Unassigned)

References

Details

Attachments

(1 file)

We don't use these permission. 

* read browser's history and bookmarks
* write browser's history and bookmarks
OS: Windows 7 → Android
Hardware: x86 → ARM
READ_HISTORY_BOOKMARKS & WRITE_HISTORY_BOOKMARKS
Assignee: nobody → kbrosnan
Summary: Don't request write/read browser's history and bookmarks → Don't request write/read stock Android browser history and bookmarks
Attached patch patchSplinter Review
Assignee: kbrosnan → mbrubeck
Status: NEW → ASSIGNED
Attachment #621102 - Flags: review?(blassey.bugs)
Blocks: 672352
blocking-fennec1.0: ? → beta+
Whiteboard: [has proposed patch]
Attachment #621102 - Flags: review?(blassey.bugs) → review-
Comment on attachment 621102 [details] [diff] [review]
patch

blassey meant to give this r+ (as he confirmed on IRC).

[Approval Request Comment]
User impact if declined: Firefox requests unnecessary permissions at install time.

Testing completed (on m-c, etc.): Just landed on m-c.

Risk to taking this patch (and alternatives if risky): Mobile-only.  Any regressions should be easy to catch -- if these permissions are actually needed, Firefox will crash with a security exception.

String changes made by this patch: None.
Attachment #621102 - Flags: review-
Attachment #621102 - Flags: review+
Attachment #621102 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/495e6cd1903d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [has proposed patch]
Target Milestone: --- → Firefox 15
Note for verifying this bug you will need to uninstall/reinstall Firefox to see the permission changes.
Comment on attachment 621102 [details] [diff] [review]
patch

[Triage comment]
Beta blocker with some bake time on m-c. Approved for Aurora 14.
Attachment #621102 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's history and bookmarks. On latest Aurora and Nightly I see read browser's history and bookmarks, is this the right behavior?
(In reply to Andreea Pod from comment #9)
> On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's
> history and bookmarks. On latest Aurora and Nightly I see read browser's
> history and bookmarks, is this the right behavior?

Yes

http://hg.mozilla.org/mozilla-central/diff/d74e5dfa1626/mobile/android/base/AndroidManifest.xml.in

This is required for bug 710330.

That SUMO article will need to be updated for 15.
(In reply to Aaron Train [:aaronmt] from comment #10)
> (In reply to Andreea Pod from comment #9)
> > On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's
> > history and bookmarks. On latest Aurora and Nightly I see read browser's
> > history and bookmarks, is this the right behavior?
> 
> Yes
> 
> http://hg.mozilla.org/mozilla-central/diff/d74e5dfa1626/mobile/android/base/
> AndroidManifest.xml.in
> 
> This is required for bug 710330.
> 
> That SUMO article will need to be updated for 15.

Ok, then marking this as verified fixed.
Assignee: mbrubeck → nobody
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.