751930 - Don't request write/read stock Android browser history and bookmarks

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

We don't use these permission. 

* read browser's history and bookmarks
* write browser's history and bookmarks

Comment 1

[Aaron Train [:aaronmt]]

READ_HISTORY_BOOKMARKS & WRITE_HISTORY_BOOKMARKS

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 621102 [details] [diff] [review]
patch

blassey meant to give this r+ (as he confirmed on IRC).

[Approval Request Comment]
User impact if declined: Firefox requests unnecessary permissions at install time.

Testing completed (on m-c, etc.): Just landed on m-c.

Risk to taking this patch (and alternatives if risky): Mobile-only.  Any regressions should be easy to catch -- if these permissions are actually needed, Firefox will crash with a security exception.

String changes made by this patch: None.

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/495e6cd1903d

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Note for verifying this bug you will need to uninstall/reinstall Firefox to see the permission changes.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 621102 [details] [diff] [review]
patch

[Triage comment]
Beta blocker with some bake time on m-c. Approved for Aurora 14.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe490ee60a29

Comment 8

[Matt Brubeck (:mbrubeck)]

Submitted a revision to the SUMO article:
https://support.mozilla.org/en-US/kb/how-firefox-android-use-permissions-it-requests/revision/23883

Comment 9

[Andreea Pod]

On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's history and bookmarks. On latest Aurora and Nightly I see read browser's history and bookmarks, is this the right behavior?

Comment 10

[Aaron Train [:aaronmt]]

(In reply to Andreea Pod from comment #9)
> On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's
> history and bookmarks. On latest Aurora and Nightly I see read browser's
> history and bookmarks, is this the right behavior?

Yes

http://hg.mozilla.org/mozilla-central/diff/d74e5dfa1626/mobile/android/base/AndroidManifest.xml.in

This is required for bug 710330.

That SUMO article will need to be updated for 15.

Comment 11

[Andreea Pod]

(In reply to Aaron Train [:aaronmt] from comment #10)
> (In reply to Andreea Pod from comment #9)
> > On Firefox Beta 14.0 (2012-06-28) I can't see any read/write browser's
> > history and bookmarks. On latest Aurora and Nightly I see read browser's
> > history and bookmarks, is this the right behavior?
> 
> Yes
> 
> http://hg.mozilla.org/mozilla-central/diff/d74e5dfa1626/mobile/android/base/
> AndroidManifest.xml.in
> 
> This is required for bug 710330.
> 
> That SUMO article will need to be updated for 15.

Ok, then marking this as verified fixed.