Closed Bug 752031 Opened 9 years ago Closed 9 years ago

Librarify the jsrefest suite

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch v0Splinter Review
Put all the random .py files in tests into a lib dir.  Totally trivial.
Attachment #621161 - Flags: review?(dmandelin)
Comment on attachment 621161 [details] [diff] [review]
v0

Review of attachment 621161 [details] [diff] [review]:
-----------------------------------------------------------------

Missing the moved files?
Attachment #621161 - Flags: review?(dmandelin)
Wow, that's odd.  The "Details" link shows:

diff --git a/js/src/tests/lib/__init__.py b/js/src/tests/lib/__init__.py
new file mode 100644
diff --git a/js/src/tests/manifest.py b/js/src/tests/lib/manifest.py
rename from js/src/tests/manifest.py
rename to js/src/tests/lib/manifest.py
diff --git a/js/src/tests/progressbar.py b/js/src/tests/lib/progressbar.py
rename from js/src/tests/progressbar.py
rename to js/src/tests/lib/progressbar.py
diff --git a/js/src/tests/results.py b/js/src/tests/lib/results.py
rename from js/src/tests/results.py
rename to js/src/tests/lib/results.py
diff --git a/js/src/tests/tasks_unix.py b/js/src/tests/lib/tasks_unix.py
rename from js/src/tests/tasks_unix.py
rename to js/src/tests/lib/tasks_unix.py
diff --git a/js/src/tests/tasks_win.py b/js/src/tests/lib/tasks_win.py
rename from js/src/tests/tasks_win.py
rename to js/src/tests/lib/tasks_win.py
diff --git a/js/src/tests/tests.py b/js/src/tests/lib/tests.py
rename from js/src/tests/tests.py
rename to js/src/tests/lib/tests.py

at the bottom, but the Diff and Splinter Review links don't mention these files at all.
Attachment #621161 - Flags: review?(dmandelin)
Comment on attachment 621161 [details] [diff] [review]
v0

Oh, OK, it looks like Splinter wasn't smart enough to pick up the moves.
Attachment #621161 - Flags: review?(dmandelin) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.