Closed
Bug 752031
Opened 13 years ago
Closed 13 years ago
Librarify the jsrefest suite
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
3.20 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Put all the random .py files in tests into a lib dir. Totally trivial.
Attachment #621161 -
Flags: review?(dmandelin)
![]() |
||
Comment 1•13 years ago
|
||
Comment on attachment 621161 [details] [diff] [review]
v0
Review of attachment 621161 [details] [diff] [review]:
-----------------------------------------------------------------
Missing the moved files?
Attachment #621161 -
Flags: review?(dmandelin)
Assignee | ||
Comment 2•13 years ago
|
||
Wow, that's odd. The "Details" link shows:
diff --git a/js/src/tests/lib/__init__.py b/js/src/tests/lib/__init__.py
new file mode 100644
diff --git a/js/src/tests/manifest.py b/js/src/tests/lib/manifest.py
rename from js/src/tests/manifest.py
rename to js/src/tests/lib/manifest.py
diff --git a/js/src/tests/progressbar.py b/js/src/tests/lib/progressbar.py
rename from js/src/tests/progressbar.py
rename to js/src/tests/lib/progressbar.py
diff --git a/js/src/tests/results.py b/js/src/tests/lib/results.py
rename from js/src/tests/results.py
rename to js/src/tests/lib/results.py
diff --git a/js/src/tests/tasks_unix.py b/js/src/tests/lib/tasks_unix.py
rename from js/src/tests/tasks_unix.py
rename to js/src/tests/lib/tasks_unix.py
diff --git a/js/src/tests/tasks_win.py b/js/src/tests/lib/tasks_win.py
rename from js/src/tests/tasks_win.py
rename to js/src/tests/lib/tasks_win.py
diff --git a/js/src/tests/tests.py b/js/src/tests/lib/tests.py
rename from js/src/tests/tests.py
rename to js/src/tests/lib/tests.py
at the bottom, but the Diff and Splinter Review links don't mention these files at all.
Assignee | ||
Updated•13 years ago
|
Attachment #621161 -
Flags: review?(dmandelin)
![]() |
||
Comment 3•13 years ago
|
||
Comment on attachment 621161 [details] [diff] [review]
v0
Oh, OK, it looks like Splinter wasn't smart enough to pick up the moves.
Attachment #621161 -
Flags: review?(dmandelin) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment 5•13 years ago
|
||
Target Milestone: --- → mozilla15
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•