Support building SpiderMonkey without JS_HAS_XML_SUPPORT

RESOLVED FIXED in mozilla15

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla15
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This is something Terrence needs for GC work, and it'll help us remove XML support eventually.
(Assignee)

Comment 1

5 years ago
Created attachment 621208 [details] [diff] [review]
v1

This leaves JS_HAS_XML_SUPPORT defined for now, but rearranges the #ifdefs so that it'll compile if you manually hack jsversion.h and turn it off.

Terrence told me he's working on a patch for this too. I trust his patch more since he's actually going to be building with E4X support off, probably for months.
Comment on attachment 621208 [details] [diff] [review]
v1

Review of attachment 621208 [details] [diff] [review]:
-----------------------------------------------------------------

This all looks perfectly straightforward.  I don't think we have to wait for getting the tests to work before committing this since it still defaults to off.

Also, double plus bonus points if you add --disable-e4x to configure -- it should be easy as easy as copying the block for --disable-incremental and updating the variable names.
Attachment #621208 - Flags: review+
(Assignee)

Updated

5 years ago
Blocks: 752632
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8be72d70f108
https://hg.mozilla.org/mozilla-central/rev/8be72d70f108
Assignee: general → jorendorff
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.