752092 - Support building SpiderMonkey without JS_HAS_XML_SUPPORT

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

This is something Terrence needs for GC work, and it'll help us remove XML support eventually.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

This leaves JS_HAS_XML_SUPPORT defined for now, but rearranges the #ifdefs so that it'll compile if you manually hack jsversion.h and turn it off.

Terrence told me he's working on a patch for this too. I trust his patch more since he's actually going to be building with E4X support off, probably for months.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 621208 [details] [diff] [review]
v1

Review of attachment 621208 [details] [diff] [review]:
-----------------------------------------------------------------

This all looks perfectly straightforward.  I don't think we have to wait for getting the tests to work before committing this since it still defaults to off.

Also, double plus bonus points if you add --disable-e4x to configure -- it should be easy as easy as copying the block for --disable-incremental and updating the variable names.

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8be72d70f108

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8be72d70f108