Last Comment Bug 752121 - IonMonkey: Disable C1/JSON Spewers in debug builds
: IonMonkey: Disable C1/JSON Spewers in debug builds
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: David Anderson [:dvander]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: IonGreen
  Show dependency treegraph
Reported: 2012-05-04 18:02 PDT by David Anderson [:dvander]
Modified: 2012-05-11 17:32 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (4.20 KB, patch)
2012-05-10 17:24 PDT, David Anderson [:dvander]
no flags Details | Diff | Splinter Review
v2 (3.76 KB, patch)
2012-05-11 16:59 PDT, David Anderson [:dvander]
sstangl: review+
Details | Diff | Splinter Review

Description User image David Anderson [:dvander] 2012-05-04 18:02:17 PDT

Comment 1 User image David Anderson [:dvander] 2012-05-10 17:24:22 PDT
Created attachment 622981 [details] [diff] [review]
Comment 2 User image David Anderson [:dvander] 2012-05-10 17:26:41 PDT
This patch enables ion.cfg/ion.json logging in the shell, but disables it in the browser. You can get it back in the browser by setting IONFLAGS to any of its options.
Comment 3 User image Sean Stangl [:sstangl] 2012-05-11 15:59:49 PDT
Comment on attachment 622981 [details] [diff] [review]

Review of attachment 622981 [details] [diff] [review]:

The patch is fine, but it doesn't disable spew for the browser: IonSpewNewFunction(), at the top of TestCompiler(), will call the init() function anyway. That needs to be changed to check against inited_, and EnableIonDebugLogging() should be the sole caller of init().

I think this patch should actually go further and disable spew in the shell by default also. That would let the testsuite run more quickly, and will give us less of a surprise on long-running (emscripten) tests where JSON files of hundreds of megabytes are silently built.
Comment 4 User image David Anderson [:dvander] 2012-05-11 16:59:33 PDT
Created attachment 623366 [details] [diff] [review]

Good catch - I agree, let's disable in the shell too. IONFLAGS=logs gets it back.
Comment 5 User image Sean Stangl [:sstangl] 2012-05-11 17:06:05 PDT
Comment on attachment 623366 [details] [diff] [review]

Review of attachment 623366 [details] [diff] [review]:

::: js/src/shell/js.cpp
@@ +101,5 @@
>  #include "jsinterpinlines.h"
>  #include "jsobjinlines.h"
>  #include "jsscriptinlines.h"
>  #include "ion/Ion.h"
> +#include "ion/IonSpewer.h"

Not needed anymore :)
Comment 6 User image David Anderson [:dvander] 2012-05-11 17:32:16 PDT

Note You need to log in before you can comment on or make changes to this bug.