752121 - IonMonkey: Disable C1/JSON Spewers in debug builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

This patch enables ion.cfg/ion.json logging in the shell, but disables it in the browser. You can get it back in the browser by setting IONFLAGS to any of its options.

Comment 3

[Sean Stangl [:sstangl]]

Comment on attachment 622981 [details] [diff] [review]
fix

Review of attachment 622981 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but it doesn't disable spew for the browser: IonSpewNewFunction(), at the top of TestCompiler(), will call the init() function anyway. That needs to be changed to check against inited_, and EnableIonDebugLogging() should be the sole caller of init().

I think this patch should actually go further and disable spew in the shell by default also. That would let the testsuite run more quickly, and will give us less of a surprise on long-running (emscripten) tests where JSON files of hundreds of megabytes are silently built.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

Good catch - I agree, let's disable in the shell too. IONFLAGS=logs gets it back.

Comment 5

[Sean Stangl [:sstangl]]

Comment on attachment 623366 [details] [diff] [review]
v2

Review of attachment 623366 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +101,5 @@
>  #include "jsinterpinlines.h"
>  #include "jsobjinlines.h"
>  #include "jsscriptinlines.h"
>  #include "ion/Ion.h"
> +#include "ion/IonSpewer.h"

Not needed anymore :)

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/ionmonkey/rev/c0537e1c5e8b