IonMonkey: Disable C1/JSON Spewers in debug builds

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 622981 [details] [diff] [review]
fix
Attachment #622981 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #622981 - Flags: review? → review?(sstangl)
(Assignee)

Comment 2

5 years ago
This patch enables ion.cfg/ion.json logging in the shell, but disables it in the browser. You can get it back in the browser by setting IONFLAGS to any of its options.
Comment on attachment 622981 [details] [diff] [review]
fix

Review of attachment 622981 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine, but it doesn't disable spew for the browser: IonSpewNewFunction(), at the top of TestCompiler(), will call the init() function anyway. That needs to be changed to check against inited_, and EnableIonDebugLogging() should be the sole caller of init().

I think this patch should actually go further and disable spew in the shell by default also. That would let the testsuite run more quickly, and will give us less of a surprise on long-running (emscripten) tests where JSON files of hundreds of megabytes are silently built.
Attachment #622981 - Flags: review?(sstangl)
(Assignee)

Comment 4

5 years ago
Created attachment 623366 [details] [diff] [review]
v2

Good catch - I agree, let's disable in the shell too. IONFLAGS=logs gets it back.
Attachment #622981 - Attachment is obsolete: true
Attachment #623366 - Flags: review?(sstangl)
Comment on attachment 623366 [details] [diff] [review]
v2

Review of attachment 623366 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/shell/js.cpp
@@ +101,5 @@
>  #include "jsinterpinlines.h"
>  #include "jsobjinlines.h"
>  #include "jsscriptinlines.h"
>  #include "ion/Ion.h"
> +#include "ion/IonSpewer.h"

Not needed anymore :)
Attachment #623366 - Flags: review?(sstangl) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/c0537e1c5e8b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.