752125 - [AccessFu] Switch to a role-based traversal rule

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

For simplicitly, I originally implemented a traversal rule that lands on all leaves and reads their unique lineage. This has ended up being problematic. For example dijit widgets don't have an action assigned to the text leaf at the tip of a widget.

TinyMCE's toolbar has empty paragraphs at the tip of its buttons, using aria-labelledby instead.

So to be more agnostic as to how a widget is implemented, be it native or aria, we should probably switch over to a role traversal rule. And if needed, have more logic for specific roles in the match function.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Switch to a role-based traversal rule.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

I want to go over some high level stuff with you before review (probably Monday).

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 621232 [details] [diff] [review]
Switch to a role-based traversal rule.

Review of attachment 621232 [details] [diff] [review]:
-----------------------------------------------------------------

ok r=me

::: accessible/src/jsat/VirtualCursorController.jsm
@@ +120,5 @@
>  
>      preFilter: Ci.nsIAccessibleTraversalRule.PREFILTER_DEFUNCT |
>        Ci.nsIAccessibleTraversalRule.PREFILTER_INVISIBLE,
>  
>      match: function(aAccessible) {

tempting to do let rule=Ci.nsIAccessibleRole and case rule.ROLE_FOO

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Actually we could consider consts like we do in our mochitests.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #4)
> Actually we could consider consts like we do in our mochitests.

Yeah, this is a bigger problem in this module, event consts too. Need to open a bug for that.

Comment 6

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/b31f41a3fffa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/b31f41a3fffa