The default bug view has changed. See this FAQ.

[AccessFu] Switch to a role-based traversal rule

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla15
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
For simplicitly, I originally implemented a traversal rule that lands on all leaves and reads their unique lineage. This has ended up being problematic. For example dijit widgets don't have an action assigned to the text leaf at the tip of a widget.

TinyMCE's toolbar has empty paragraphs at the tip of its buttons, using aria-labelledby instead.

So to be more agnostic as to how a widget is implemented, be it native or aria, we should probably switch over to a role traversal rule. And if needed, have more logic for specific roles in the match function.
(Assignee)

Comment 1

5 years ago
Created attachment 621232 [details] [diff] [review]
Switch to a role-based traversal rule.
Attachment #621232 - Flags: review?(dbolter)
I want to go over some high level stuff with you before review (probably Monday).
Comment on attachment 621232 [details] [diff] [review]
Switch to a role-based traversal rule.

Review of attachment 621232 [details] [diff] [review]:
-----------------------------------------------------------------

ok r=me

::: accessible/src/jsat/VirtualCursorController.jsm
@@ +120,5 @@
>  
>      preFilter: Ci.nsIAccessibleTraversalRule.PREFILTER_DEFUNCT |
>        Ci.nsIAccessibleTraversalRule.PREFILTER_INVISIBLE,
>  
>      match: function(aAccessible) {

tempting to do let rule=Ci.nsIAccessibleRole and case rule.ROLE_FOO
Attachment #621232 - Flags: review?(dbolter) → review+
Actually we could consider consts like we do in our mochitests.
(Assignee)

Comment 5

5 years ago
(In reply to David Bolter [:davidb] from comment #4)
> Actually we could consider consts like we do in our mochitests.

Yeah, this is a bigger problem in this module, event consts too. Need to open a bug for that.
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/b31f41a3fffa
http://hg.mozilla.org/mozilla-central/rev/b31f41a3fffa
Assignee: nobody → eitan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.