752127 - [AccessFu] Abolish anonymous functions

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

{
  foo: function(arg) {}
}

should be
{
  foo: function foo(arg) {}
}

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Provide names to all functions that are not in-line. Remove some dumps, wrap some lines.

From now on, introducing anonymous functions is a sin!

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 622917 [details] [diff] [review]
Provide names to all functions that are not in-line. Remove some dumps, wrap some lines.

Review of attachment 622917 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if you want to do your mock private-ness via underscore prefixes while you are here? What is the b2g/ff style guide say about that?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

What is your rule for naming functions? Is it
objectname_functionname or just functionname? (you have a mix I think)

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 622917 [details] [diff] [review]
> Provide names to all functions that are not in-line. Remove some dumps, wrap
> some lines.
> 
> Review of attachment 622917 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I wonder if you want to do your mock private-ness via underscore prefixes
> while you are here? What is the b2g/ff style guide say about that?

We should do that for consistency. I'll upload another patch.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #3)
> What is your rule for naming functions? Is it
> objectname_functionname or just functionname? (you have a mix I think)

If it is a subclass or an implementation of an interface, I prefix the function name with the object name.

Comment 6

[Eitan Isaacson [:eeejay]]

Attachment: Bug 752127 - Provide names to all functions that are not in-line. Remove some dumps, wrap some lines.

I "privatized" the methods that are internal utility functions. The ones that I didn't touch are ones that I think will be useful API in a future addon, or ones that are required for interfaces (observe, handleEvent).

Comment 7

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5a911d6449b1

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a911d6449b1