The default bug view has changed. See this FAQ.

[AccessFu] Do not return empty string elements in utterances

RESOLVED FIXED in mozilla15

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla15
x86_64
Linux
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Originally I chose to not filter out empty strings from utterances. With the thought that ATs could have some understanding about how the utterance is constructed and modify their presentation. For example on a focus event, strings in odd indexes are names or values, strings in even indexes are roles or descriptions.

The problem is that it seems like TalkBack delimits each element from the utterance with spaces, so if you land on plain text, and the utterance (in Android it is AccessibilityEvent.getText()) would be ['', 'some text']. This would be sent to the TTS as ' some text'. the preceding whitespace delays the speech, so users get a laggy experience (well a more laggy experience :)
(Assignee)

Comment 1

5 years ago
Created attachment 621234 [details] [diff] [review]
Remove empty strings from utterances.

This should do it. Nothing too fancy.

It feels liberating not to have to return two elements each time. I might suggest later on not clumping roles and states into the previous "description" element and to have them seperate. This introduces interesting questions about the grammar boundaries, and how things should be localized.
Attachment #621234 - Flags: review?(dbolter)
I want to go over some high level stuff with you before review (probably Monday).

Updated

5 years ago
Attachment #621234 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/53face03b63f
http://hg.mozilla.org/mozilla-central/rev/53face03b63f
Assignee: nobody → eitan
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.