Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Skips corrupted attendees with a null id when reading items from storage, and also makes the isInvitation function more tolerant of the condition in case any other providers were affected.
Attachment #623460 - Flags: review?(mohit.kanwal)
Comment on attachment 623460 [details] [diff] [review] Fix v1 Review of attachment 623460 [details] [diff] [review]: ----------------------------------------------------------------- Looks okay to me. Will report once I can get the STR right. Setting + in the meanwhile.
Attachment #623460 - Flags: review?(mohit.kanwal) → review+
Severity: critical → blocker
Okay I am trying to reproduce the error using the STR described above. Where do I change the calendar property of the event created ? That is step number 4. Pardon me, to sound like a n00b but I don't know the lightning components in that much detail still learning :)
(In reply to Mohit Kanwal [:redDragon] from comment #3) > Where do I change the calendar property of the event created ? Sorry, I should have clarified: open the event in the Edit Event dialog, and change the event's calendar using the Calendar dropdown, then Save and Close to move the event to the storage calendar.
Hi Matt, I tested the patch with Lightning 1.2 and 1.3 and was able to reproduce the STR and managed to get the item to disappear from the view. After applying the patch, the item comes back to the view. However there is one additional issue, after updating lightning with the patch (Maybe I am doing this wrong, I am using xpi to add/remove add-ons while not touching the profile folder at all) . I get this error message, and I can no longer add events to my Google Calendar. Error: [Exception... "'TypeError: aItem.getProperty is not a function' when calling method: [calIOperationListener::onOperationComplete]" nsresult: "0x8057001c (NS_ERROR_XPC_JS_THREW_JS_OBJECT)" location: "JS frame :: resource://calendar/modules/calProviderUtils.jsm :: cPB_notifyOperationComplete :: line 694" data: no] It is possible that my method (using XPIs to install/remove add ons might have caused this, i am not sure about it maybe you can shed some light. Also I shall update the patch to apply cleanly on the current trunk vers ion.
(In reply to Mohit Kanwal [:redDragon] from comment #5) > issue, after updating lightning with the patch (Maybe I am doing this wrong, > I am using xpi to add/remove add-ons while not touching the profile folder > at all) . I get this error message, and I can no longer add events to my > Google Calendar. Did you do this test with a build from comm-central? If so could you try it with the patch for Bug 757332 applied? Also, did you update the Google Calendar Provider xpi as well as Lightning?
Yup i built it from comm-central updated about the same time i submitted the previous comment. Updated Google Calendar xpi as well as Lightning. I think I will try with the fix for bug 757332 applied. It is possible it may be broken coz of that, but so far works as expected for the purpose of this bug, ignoring the null value of the attendee_id column and displaying it correctly in the view which was missing with lightning 1.3.
After applying the fix for bug 757332 and rebuilding I can write events to my Google Calendar again.
Comment on attachment 626298 [details] [diff] [review] Clean Patch to apply on trunk This patch looks broken because it contains multiple but different diffs for the same file.
Comment on attachment 623460 [details] [diff] [review] Fix v1 Problem was reported from 1.4 therefore it should be considered for the upcoming 1.5 release too.
Ok corrected, I think this should be the version.
Attachment #626298 - Attachment is obsolete: true
Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/80217824a340
Comment on attachment 623460 [details] [diff] [review] Fix v1 Yes, go ahead.
Pushed to comm-aurora - http://hg.mozilla.org/releases/comm-aurora/rev/29c9c656e43c
Pushed to comm-beta - http://hg.mozilla.org/releases/comm-beta/rev/b1271b77793a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.