752203 - Cleanup nsEditor::NodesSameType

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1.1

Now it also builds.

Comment 2

[(no longer active)]

Comment on attachment 621286 [details] [diff] [review]
Patch v1.1

Review of attachment 621286 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall, r- because of the comment below.

::: editor/libeditor/base/nsEditor.cpp
@@ +3844,5 @@
> +
> +  nsCOMPtr<nsIContent> content1 = do_QueryInterface(aNode1);
> +  nsCOMPtr<nsIContent> content2 = do_QueryInterface(aNode2);
> +  if (!content1 || !content2) {
> +    return !content1 == !content2;

Hmm, is why do we want to do this?  This means that when content1 and content2 are both null, we'll consider them to be the same type.  I don't see why that makes sense.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Me neither, but I wanted to preserve behaviour (both GetTag's would return null in that case, so they would compare equal)

Comment 4

[(no longer active)]

(In reply to Ms2ger from comment #3)
> Me neither, but I wanted to preserve behaviour (both GetTag's would return
> null in that case, so they would compare equal)

Hmm, then I think the existing behavior is badly broken, let's fix it.  :-)

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

wfm

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/f7d7fad55752