Switch Paris binding double/int64 wrapping away from JS_NewNumberValue once we have a better API

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bz, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Depends on bug 752223

Comment 1

5 years ago
This should also be resolved by the patch in 752223, as the bindings were changed when JS_NewNumberValue() went away and was replaced by an always inlined non-footgunny version with the same functionality. Is this sufficient? We will still need to do something about the WebIDL [Clamp] rounding thing, as Boris suggests.
What [Clamp] thing?

What we have after bug 752223 seems pretty reasonable to me, unless it would be better to use DOUBLE_TO_JSVAL for the float/double cases.  Whether that's better sort of depends on the jit and on what sorts of values usually come out of such properties, right?

Probably worth a separate bug on that if we think it's useful.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.