Closed Bug 752319 Opened 9 years ago Closed 9 years ago

Use testharness.js for the cross-origin localStorage tests

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
I'd like to submit those to the W3C test suite, so they need to use testharness.js (<http://w3c-test.org/resources/testharness.js>). Could you have a look?
Attachment #621423 - Flags: review?(honzab.moz)
Comment on attachment 621423 [details] [diff] [review]
Patch v1

Review of attachment 621423 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Looks good.

::: dom/tests/mochitest/localstorage/interOriginTest2.js
@@ +1,1 @@
> +var t = async_test(document.title);

So, this ensures the asynchronicity and allows removal of SimpleTest.waitForExplicitFinish() from the main page?

@@ +45,5 @@
>  
>      // Any other message indicates error, succes or todo message of a test
>      default:
> +      t.step(function() {
> +        assert_true(!event.data.match(failureRegExp), event.data);

So we no longer has TODOs?
Attachment #621423 - Flags: review?(honzab.moz) → review+
Comment on attachment 621423 [details] [diff] [review]
Patch v1

Too early pressed enter....

I cannot run http://mochi.test:8888/tests/dom/tests/mochitest/localstorage/test_keySync.html it self w/ this patch.
Attachment #621423 - Flags: review+ → review-
Attached patch Patch v2Splinter Review
This should give you logs when running tests on their own. I also removed remnants of the todo support, as we don't have any left.
Attachment #621423 - Attachment is obsolete: true
Attachment #621646 - Flags: review?(honzab.moz)
Comment on attachment 621646 [details] [diff] [review]
Patch v2

Review of attachment 621646 [details] [diff] [review]:
-----------------------------------------------------------------

So, all tests using testharness.js needs to define <div id="log"></div>.  Good to know.
Attachment #621646 - Flags: review?(honzab.moz) → review+
https://hg.mozilla.org/mozilla-central/rev/75a6378de201
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.