752319 - Use testharness.js for the cross-origin localStorage tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

I'd like to submit those to the W3C test suite, so they need to use testharness.js (<http://w3c-test.org/resources/testharness.js>). Could you have a look?

Comment 1

[Honza Bambas (:mayhemer)]

Comment on attachment 621423 [details] [diff] [review]
Patch v1

Review of attachment 621423 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Looks good.

::: dom/tests/mochitest/localstorage/interOriginTest2.js
@@ +1,1 @@
> +var t = async_test(document.title);

So, this ensures the asynchronicity and allows removal of SimpleTest.waitForExplicitFinish() from the main page?

@@ +45,5 @@
>  
>      // Any other message indicates error, succes or todo message of a test
>      default:
> +      t.step(function() {
> +        assert_true(!event.data.match(failureRegExp), event.data);

So we no longer has TODOs?

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 621423 [details] [diff] [review]
Patch v1

Too early pressed enter....

I cannot run http://mochi.test:8888/tests/dom/tests/mochitest/localstorage/test_keySync.html it self w/ this patch.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v2

This should give you logs when running tests on their own. I also removed remnants of the todo support, as we don't have any left.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 621646 [details] [diff] [review]
Patch v2

Review of attachment 621646 [details] [diff] [review]:
-----------------------------------------------------------------

So, all tests using testharness.js needs to define <div id="log"></div>.  Good to know.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/75a6378de201