752431 - FileHandle: Support 64 bit file sizes

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jan Varga [:janv]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=726593#c33

@@ +58,5 @@
> +    default:
> +      whence = -1;
> +  }
> +
> +  int rc = sqlite3_quota_fseek(mQuotaFile, aOffset, whence);

This will truncate aOffset. Need to NS_ENSURE that aOffset < PR_INT32_MAX, and we need to make sure we don't deal with bigger sizes anywhere else in this code.

We probably should file a bug to update this all to handle 64bit file sizes, and we need to get the sqlite guys to change their api to do it.

Comment 1

[Jan Varga [:janv]]

This won't be an issue once the initial quota manager lands, bug 787804

Comment 2

[Jan Varga [:janv]]

We no longer use sqlite3_quota_* API. The streams introduced in bug 787804 should support 64 bit file sizes just fine.