First time after choosing to "Never activate plugins for this site" the video is still playing

VERIFIED FIXED in mozilla15

Status

()

Core
Plug-ins
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: pauly, Assigned: keeler)

Tracking

14 Branch
mozilla15
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
STR:
1. Make sure plugins.click_to_play pref is set on TRUE in about:config
2. Open http://www.youtube.com/
3. Click on a video
4. Click on the plugin icon in the location bar
5. Choose to "Never activate plugins for this site"
6. Click on the video screen

Expected results:
The video should not play

Actual results:
The video starts playing
To clarify, are you saying that if a user chooses "Never activate plugins...", when they then click on a plugin, it should not play? If so, I think this might confuse users ("I clicked on the plugin, but it's not playing?"). In fact, I think we should get rid of the "never activate plugins..." option altogether, because all we're really saying there is "never activate plugins automatically on this site", which is what happens if you have click-to-play enabled in the first place.
Fixing this bug is pretty simple, we should just iterate through the plugins array and hide the overlay.

As far as the ability to always deny, the benefit is that viewing pages doesn't show the overlay and the notification icon won't appear. I don't think we should remove this ability.
Created attachment 622134 [details] [diff] [review]
patch + test
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #622134 - Flags: review?(joshmoz)
Comment on attachment 622134 [details] [diff] [review]
patch + test

Review of attachment 622134 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks :)
Attachment #622134 - Flags: feedback+
Comment on attachment 622134 [details] [diff] [review]
patch + test

Review of attachment 622134 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the one change mentioned below.

::: browser/base/content/browser.js
@@ +7333,5 @@
>                              messageString, "plugins-notification-icon",
>                              mainAction, secondaryActions, options);
>    },
>  
> +  removeClickToPlayOverlays: function (aContentWindow) {

Please put an underscore in front of the function name here and name the anonymous function PH_removeClickToPlayOverlays.
Attachment #622134 - Flags: review?(joshmoz) → review+
Created attachment 622152 [details] [diff] [review]
patch v2 + test

Updated patch per jaws' comments. Carrying over r+
Try run: https://tbpl.mozilla.org/?tree=Try&rev=9c46687a0659
Attachment #622134 - Attachment is obsolete: true
Attachment #622152 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/23f45cac342f
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/23f45cac342f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

5 years ago
Black screen instantly appears when choosing to "Never activate plugins for this site".
Verified fixed on FF 15.0a1 (2012-05-10) on Win 7/64, Ubuntu 12.04 and Mac OS X 10.7.
Status: RESOLVED → VERIFIED
(Reporter)

Comment 10

5 years ago
(In reply to Jared Wein [:jaws] from comment #2)
> As far as the ability to always deny, the benefit is that viewing pages
> doesn't show the overlay and the notification icon won't appear. I don't
> think we should remove this ability.

One disadvantage of this would be that if someone else will use the computer or event the owner after a long time might don't know why youtube.com apparently doesn't work.
In fact it's the same functionality, both with or without the CtP notification.
You need to log in before you can comment on or make changes to this bug.