752505 - Copy Image broken on Nightly

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Phoenix]

Right click - Copy Image is partially broken on nightly, now instead of copying image address it copies image by itself. Firefox doesn't have problem, because have separate menu options Copy Image and Copy Image Location.
Last "good" nightly: 2012-05-02-00-30-23-comm-central-trunk
First "bad" nightly: 2012-05-03-00-30-35-comm-central-trunk
Regression from Bug 749527?

Comment 1

[Brian R. Bondy [:bbondy]]

So probably the easiest way for you to get what you want is to either:
1) Add a second menu item like Firefox has
2) If you really do want all formats on the clipboard then add a new command for:
PRInt32 copyFlags = nsIContentViewerEdit::COPY_IMAGE_ALL;

Here is similar code to what you would need to do that (Except you'd use it for COPY_IMAGE_ALL):
https://bug749527.bugzilla.mozilla.org/attachment.cgi?id=619045

Comment 2

[[e-mail]]

Attachment: Proposed patch

Comment 3

[Philip Chee]

Comment on attachment 622008 [details] [diff] [review]
Proposed patch

This patch works for me. In WordPerfect Edit->Paste Special I get a choice of
Unformatted Text
Unicode
Device Independent Bitmap

Comment 4

[Philip Chee]

Attachment: Screenshot of Clipboard Viewer

Screenshot showing all the formats available when copying an image.

Comment 5

[[e-mail]]

This code snippet works in windows with a <browser> element:

function CopyImage()
{
  var contentViewerEdit = getBrowser().contentViewerEdit;
  contentViewerEdit.copyImage(contentViewerEdit.COPY_IMAGE_ALL);
}

Unfortunately I don't know if we can rely on that.

Comment 6

[Philip Chee]

> Unfortunately I don't know if we can rely on that.
Yeah lets go with your current patch. Please push stat!

Comment 7

[[e-mail]]

Pushed changeset e2a736a2a7b0 to comm-central.

Comment 8

[[e-mail]]

Comment on attachment 622008 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 749527
User impact if declined: Unable to copy image location
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String changes made by this patch: None

Comment 9

[Philip Chee]

Pushed to comm-aurora:
http://hg.mozilla.org/releases/comm-aurora/rev/888234d04ea9
Pushed to comm-beta:
http://hg.mozilla.org/releases/comm-beta/rev/3a7dc5e2cb05