Closed
Bug 752505
Opened 12 years ago
Closed 12 years ago
Copy Image broken on Nightly
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.10 fixed, seamonkey2.11 fixed)
RESOLVED
FIXED
seamonkey2.12
People
(Reporter: mz+bugzilla, Assigned: neil)
References
Details
(Keywords: regression)
Attachments
(2 files)
1.85 KB,
patch
|
philip.chee
:
review+
philip.chee
:
approval-comm-aurora+
philip.chee
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
27.62 KB,
image/png
|
Details |
Right click - Copy Image is partially broken on nightly, now instead of copying image address it copies image by itself. Firefox doesn't have problem, because have separate menu options Copy Image and Copy Image Location. Last "good" nightly: 2012-05-02-00-30-23-comm-central-trunk First "bad" nightly: 2012-05-03-00-30-35-comm-central-trunk Regression from Bug 749527?
![]() |
||
Updated•12 years ago
|
Component: UI Design → General
QA Contact: ui-design → general
Hardware: x86_64 → Other
Comment 1•12 years ago
|
||
So probably the easiest way for you to get what you want is to either: 1) Add a second menu item like Firefox has 2) If you really do want all formats on the clipboard then add a new command for: PRInt32 copyFlags = nsIContentViewerEdit::COPY_IMAGE_ALL; Here is similar code to what you would need to do that (Except you'd use it for COPY_IMAGE_ALL): https://bug749527.bugzilla.mozilla.org/attachment.cgi?id=619045
Assignee | ||
Comment 2•12 years ago
|
||
![]() |
||
Comment 3•12 years ago
|
||
Comment on attachment 622008 [details] [diff] [review] Proposed patch This patch works for me. In WordPerfect Edit->Paste Special I get a choice of Unformatted Text Unicode Device Independent Bitmap
Attachment #622008 -
Flags: review?(philip.chee) → review+
![]() |
||
Comment 4•12 years ago
|
||
Screenshot showing all the formats available when copying an image.
Assignee | ||
Comment 5•12 years ago
|
||
This code snippet works in windows with a <browser> element: function CopyImage() { var contentViewerEdit = getBrowser().contentViewerEdit; contentViewerEdit.copyImage(contentViewerEdit.COPY_IMAGE_ALL); } Unfortunately I don't know if we can rely on that.
![]() |
||
Comment 6•12 years ago
|
||
> Unfortunately I don't know if we can rely on that.
Yeah lets go with your current patch. Please push stat!
Assignee | ||
Comment 7•12 years ago
|
||
Pushed changeset e2a736a2a7b0 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•12 years ago
|
||
Comment on attachment 622008 [details] [diff] [review] Proposed patch [Approval Request Comment] Regression caused by (bug #): 749527 User impact if declined: Unable to copy image location Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String changes made by this patch: None
Attachment #622008 -
Flags: approval-comm-beta?
Attachment #622008 -
Flags: approval-comm-aurora?
![]() |
||
Updated•12 years ago
|
Attachment #622008 -
Flags: approval-comm-beta?
Attachment #622008 -
Flags: approval-comm-beta+
Attachment #622008 -
Flags: approval-comm-aurora?
Attachment #622008 -
Flags: approval-comm-aurora+
Assignee | ||
Updated•12 years ago
|
Keywords: checkin-needed
Whiteboard: [transplant e2a736a2a7b0 to c-a, c-b]
![]() |
||
Comment 9•12 years ago
|
||
Pushed to comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/888234d04ea9 Pushed to comm-beta: http://hg.mozilla.org/releases/comm-beta/rev/3a7dc5e2cb05
Keywords: checkin-needed
OS: Windows 7 → All
Hardware: Other → All
Whiteboard: [transplant e2a736a2a7b0 to c-a, c-b]
Updated•12 years ago
|
status-seamonkey2.10:
--- → fixed
status-seamonkey2.11:
--- → fixed
Updated•11 years ago
|
tracking-seamonkey2.12:
? → ---
Target Milestone: --- → seamonkey2.12
You need to log in
before you can comment on or make changes to this bug.
Description
•