752578 - Remove JSGuardObjectNotifier and all the JS_GUARD_OBJECT* macros, use MOZ_GUARD_OBJECT* macros instead

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

We should only use one implementation of this stuff.

I'd be happy to mentor this at a future time, but I'm a bit too hosed to do it right now, alas.  :-\

Comment 1

[Jeff Walden [:Waldo]]

Attachment: 1 - Easy cases where the macros are only in the class definition

My mind turned to mush on the drive to Chicago last week, so I picked this up and finished it off, to make forward progress on something.

Comment 2

[Jeff Walden [:Waldo]]

Attachment: 2 - Trickier cases with only-parameter uses, constructors defined out-of-line, etc.

Comment 3

[Jeff Walden [:Waldo]]

Attachment: 3 - Fix instances in js/ipc (do we even build this any more?)

Comment 4

[Jeff Walden [:Waldo]]

Attachment: 4 - Remove JS_GUARD* macros

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 697064 [details] [diff] [review]
1 - Easy cases where the macros are only in the class definition

Review of attachment 697064 [details] [diff] [review]:
-----------------------------------------------------------------

No objections to this patch from my side.

::: js/src/jsapi.h
@@ +5540,2 @@
>  
>  class JSAutoByteString {

Didn't you want to move this { too?

::: js/src/jsutil.h
@@ +159,3 @@
>  template<typename T>
>  class AutoScopedAssign
>  {

Don't we have something like this in mfbt? If not, at least somewhere in Gecko... Followup please :)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 697066 [details] [diff] [review]
2 - Trickier cases with only-parameter uses, constructors defined out-of-line, etc.

Review of attachment 697066 [details] [diff] [review]:
-----------------------------------------------------------------

Or this.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 697067 [details] [diff] [review]
3 - Fix instances in js/ipc (do we even build this any more?)

Review of attachment 697067 [details] [diff] [review]:
-----------------------------------------------------------------

Bah. Do whatever you want with this code.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 697068 [details] [diff] [review]
4 - Remove JS_GUARD* macros

Review of attachment 697068 [details] [diff] [review]:
-----------------------------------------------------------------

Good riddance!

Comment 9

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e024dfa5a774
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d6c5f87f08b
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f628cbf1073
https://hg.mozilla.org/integration/mozilla-inbound/rev/01efd933f60b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e024dfa5a774
https://hg.mozilla.org/mozilla-central/rev/0d6c5f87f08b
https://hg.mozilla.org/mozilla-central/rev/7f628cbf1073
https://hg.mozilla.org/mozilla-central/rev/01efd933f60b