Closed Bug 752649 Opened 13 years ago Closed 13 years ago

ICS gps support

Categories

(Firefox OS Graveyard :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(blocking-kilimanjaro:+, blocking-basecamp:+)

RESOLVED FIXED
ProductDemo
blocking-kilimanjaro +
blocking-basecamp +

People

(Reporter: kanru, Assigned: kanru)

References

Details

Attachments

(1 file, 1 obsolete file)

GPS stopped working on galaxy s2 ics. Need to check other ICS devices.
blocking-basecamp: --- → +
Attached patch Fill empty GPS callbacks (obsolete) — Splinter Review
It turns out some vender drivers don't check the NULLness of the callbacks and crash when they try to use them.
Assignee: nobody → kchen
Attachment #629097 - Flags: review?(josh)
Conditionalize ICS only callback.
Attachment #629097 - Attachment is obsolete: true
Attachment #629097 - Flags: review?(josh)
Attachment #629107 - Flags: review?(josh)
Comment on attachment 629107 [details] [diff] [review] Fill empty GPS callbacks v1.1 I don't believe I'm a good reviewer for this. Maybe dougt or mwu instead?
Attachment #629107 - Flags: review?(josh)
Comment on attachment 629107 [details] [diff] [review] Fill empty GPS callbacks v1.1 Hi dougt, could you review this?
Attachment #629107 - Flags: review?(doug.turner)
Attachment #629107 - Flags: review?(doug.turner) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
blocking-kilimanjaro: --- → +
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: