Status

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: kanru, Assigned: kanru)

Tracking

unspecified
ProductDemo
x86_64
Linux

Firefox Tracking Flags

(blocking-kilimanjaro:+, blocking-basecamp:+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
GPS stopped working on galaxy s2 ics. Need to check other ICS devices.
blocking-basecamp: --- → +
(Assignee)

Comment 1

7 years ago
Created attachment 629097 [details] [diff] [review]
Fill empty GPS callbacks

It turns out some vender drivers don't check the NULLness of the callbacks and crash when they try to use them.
Assignee: nobody → kchen
Attachment #629097 - Flags: review?(josh)
(Assignee)

Comment 2

7 years ago
Created attachment 629107 [details] [diff] [review]
Fill empty GPS callbacks v1.1

Conditionalize ICS only callback.
Attachment #629097 - Attachment is obsolete: true
Attachment #629097 - Flags: review?(josh)
Attachment #629107 - Flags: review?(josh)

Comment 3

7 years ago
Comment on attachment 629107 [details] [diff] [review]
Fill empty GPS callbacks v1.1

I don't believe I'm a good reviewer for this. Maybe dougt or mwu instead?
Attachment #629107 - Flags: review?(josh)
(Assignee)

Comment 4

7 years ago
Comment on attachment 629107 [details] [diff] [review]
Fill empty GPS callbacks v1.1

Hi dougt, could you review this?
Attachment #629107 - Flags: review?(doug.turner)

Updated

7 years ago
Attachment #629107 - Flags: review?(doug.turner) → review+

Comment 6

7 years ago
https://hg.mozilla.org/mozilla-central/rev/00c396b0cf9a
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
blocking-kilimanjaro: --- → +
You need to log in before you can comment on or make changes to this bug.