752836 - Don't do Thunderbird builds on comm-* branches for non-Thunderbird pushes

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P3)

Description

[Mark Banner (:standard8)]

Currently pushes to comm-* that aren't to do with Thunderbird still trigger builds to occur.

If we are able to adapt the monitor, then we could ignore pushes that contain changes only to the ignorable directories. Hence we save ourselves some builder load.

Currently the ignorable directories are:

suite/
calendar/
other-licenses/*/seamonkey/
other-licenses/*/sunbird/

Comment 1

[Chris AtLee [:catlee]]

this will require changes to the thunderbird scheduler to give it different fileIsImportant function.

Comment 2

[[e-mail] (:bhearsum)]

I think we actually want to include calendar/ now, but we already exclude suite/: https://mxr.mozilla.org/build-central/source/buildbotcustom/misc.py#146

Comment 3

[Mark Banner (:standard8)]

(In reply to Ben Hearsum [:bhearsum] from comment #2)
> I think we actually want to include calendar/ now, but we already exclude
> suite/:
> https://mxr.mozilla.org/build-central/source/buildbotcustom/misc.py#146

No we don't as Lightning is now built by default in Thunderbird builds.

Comment 4

[aleth [:aleth]]

Attachment: Don't build Thunderbird on Instantbird pushes

Instantbird now lives in comm-central (bug 956609), and pushes that only affect Instantbird (and not the code shared with Thunderbird, which lives in chat/) should not trigger a Thunderbird build.

This patch is obviously untested ;)

Comment 5

[Chris AtLee [:catlee]]

Comment on attachment 8387634 [details] [diff] [review]
Don't build Thunderbird on Instantbird pushes

Review of attachment 8387634 [details] [diff] [review]:
-----------------------------------------------------------------

what could possibly go wrong?

Comment 6

[aleth [:aleth]]

Thanks for the quick review!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8387634 [details] [diff] [review]
Don't build Thunderbird on Instantbird pushes

https://hg.mozilla.org/build/buildbotcustom/rev/7590da3dfbbc

Comment 8

[Rail Aliiev [:rail]]

in production

Comment 9

[Mark Banner (:standard8)]

Attachment: Turn it on for all branches

We've got the config set up in the previous patches, but we haven't turned this on at all yet.

As the last good nightly changes have been turned off, I think we can just enable this on all of Thunderbird's branches now, and it won't matter.

I think GLOBAL_VARS is the right/easiest place to do this, let me know if it isn't.

Comment 10

[Mark Banner (:standard8)]

@catlee Ping for review

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8405282 [details] [diff] [review]
Turn it on for all branches

Switching reviewers as this is still waiting...

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 8405282 [details] [diff] [review]
Turn it on for all branches

https://hg.mozilla.org/build/buildbot-configs/rev/b27a1906c788

Comment 13

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #12)
> Comment on attachment 8405282 [details] [diff] [review]
> Turn it on for all branches
> 
> https://hg.mozilla.org/build/buildbot-configs/rev/b27a1906c788

Somehow I'd managed to land that on production directly :-( Here's the default push:

https://hg.mozilla.org/build/buildbot-configs/rev/872b7156117f