Don't do Thunderbird builds on comm-* branches for non-Thunderbird pushes

RESOLVED FIXED

Status

Release Engineering
General
P3
enhancement
RESOLVED FIXED
6 years ago
2 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [thunderbird][buildbot])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Currently pushes to comm-* that aren't to do with Thunderbird still trigger builds to occur.

If we are able to adapt the monitor, then we could ignore pushes that contain changes only to the ignorable directories. Hence we save ourselves some builder load.

Currently the ignorable directories are:

suite/
calendar/
other-licenses/*/seamonkey/
other-licenses/*/sunbird/
this will require changes to the thunderbird scheduler to give it different fileIsImportant function.
Priority: -- → P3
Whiteboard: [thunderbird][buildbot]
(Assignee)

Updated

6 years ago
Summary: Don't do Thunderbird builds con comm-* branches for non-Thunderbird pushes → Don't do Thunderbird builds on comm-* branches for non-Thunderbird pushes
(Assignee)

Updated

6 years ago
Blocks: 787208
(Assignee)

Updated

6 years ago
Depends on: 787449
Product: mozilla.org → Release Engineering
I think we actually want to include calendar/ now, but we already exclude suite/: https://mxr.mozilla.org/build-central/source/buildbotcustom/misc.py#146
(Assignee)

Comment 3

5 years ago
(In reply to Ben Hearsum [:bhearsum] from comment #2)
> I think we actually want to include calendar/ now, but we already exclude
> suite/:
> https://mxr.mozilla.org/build-central/source/buildbotcustom/misc.py#146

No we don't as Lightning is now built by default in Thunderbird builds.

Comment 4

4 years ago
Created attachment 8387634 [details] [diff] [review]
Don't build Thunderbird on Instantbird pushes

Instantbird now lives in comm-central (bug 956609), and pushes that only affect Instantbird (and not the code shared with Thunderbird, which lives in chat/) should not trigger a Thunderbird build.

This patch is obviously untested ;)
Attachment #8387634 - Flags: review?(catlee)
Comment on attachment 8387634 [details] [diff] [review]
Don't build Thunderbird on Instantbird pushes

Review of attachment 8387634 [details] [diff] [review]:
-----------------------------------------------------------------

what could possibly go wrong?
Attachment #8387634 - Flags: review?(catlee) → review+

Comment 6

4 years ago
Thanks for the quick review!
Keywords: checkin-needed
Keywords: checkin-needed
in production
(Assignee)

Comment 9

4 years ago
Created attachment 8405282 [details] [diff] [review]
Turn it on for all branches

We've got the config set up in the previous patches, but we haven't turned this on at all yet.

As the last good nightly changes have been turned off, I think we can just enable this on all of Thunderbird's branches now, and it won't matter.

I think GLOBAL_VARS is the right/easiest place to do this, let me know if it isn't.
Attachment #8405282 - Flags: review?(catlee)
(Assignee)

Updated

4 years ago
Assignee: nobody → standard8
(Assignee)

Comment 10

4 years ago
@catlee Ping for review
(Assignee)

Comment 11

4 years ago
Comment on attachment 8405282 [details] [diff] [review]
Turn it on for all branches

Switching reviewers as this is still waiting...
Attachment #8405282 - Flags: review?(catlee)
Attachment #8405282 - Flags: review?(bhearsum)
Attachment #8405282 - Flags: review?
(Assignee)

Updated

4 years ago
Attachment #8405282 - Flags: review?
Attachment #8405282 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 13

4 years ago
(In reply to Mark Banner (:standard8) from comment #12)
> Comment on attachment 8405282 [details] [diff] [review]
> Turn it on for all branches
> 
> https://hg.mozilla.org/build/buildbot-configs/rev/b27a1906c788

Somehow I'd managed to land that on production directly :-( Here's the default push:

https://hg.mozilla.org/build/buildbot-configs/rev/872b7156117f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.