752881 - [Rule View / Computed View] Show color values "As authored"

Status: RESOLVED DUPLICATE of bug 984880

(DevTools :: Inspector, defect, P2)

Description

[Paul Rouget [:paul]]

When it's possible, we should show values as authored (color formats and dimension units).

Comment 1

[Paul Rouget [:paul]]

Bug triage, filter on PINKISBEAUTIFUL

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: styles-as-authored-752881.patch WIP

computedStyle.getAuthoredPropertyValue() currently returns the computed value so we need to wait on bug 958118

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

See http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/styles.js#150

getPropertyValue() needs to be changed to getAuthoredPropertyValue() once bug 958118 is fixed.

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4)
> See
> http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/
> styles.js#150
> 
> getPropertyValue() needs to be changed to getAuthoredPropertyValue() once
> bug 958118 is fixed.

Seems like we will need to calculate these values ourselves from within the actor.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

After some discussion we have decided that showing rgb values in the computed view and values as authored in the applied selectors is correct. I still need to fix broken tests.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I believe that tromey has been working on this, assigning it to him.

Comment 8

[Tom Tromey :tromey]

I think this was fixed by bug 984880.