Last Comment Bug 752953 - Typo in calculation of 'allowExpansion' (result will always be an empty rect) in nsDisplayScrollLayer::ComputeVisibility
: Typo in calculation of 'allowExpansion' (result will always be an empty rect)...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mats Palmgren (vacation)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-08 09:46 PDT by Mats Palmgren (vacation)
Modified: 2012-05-10 07:41 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
part 1, fix typo (1.13 KB, patch)
2012-05-08 09:54 PDT, Mats Palmgren (vacation)
roc: review+
Details | Diff | Splinter Review
part 2, simplify IntersectRect calculations (5.12 KB, patch)
2012-05-08 09:58 PDT, Mats Palmgren (vacation)
roc: review+
Details | Diff | Splinter Review

Comment 1 Mats Palmgren (vacation) 2012-05-08 09:54:01 PDT
Created attachment 622017 [details] [diff] [review]
part 1, fix typo

Looking at the 'allowExpansion' calculations in nsDisplayOpacity/nsDisplayClip
I guess this is what was intended.
Comment 2 Mats Palmgren (vacation) 2012-05-08 09:58:47 PDT
Created attachment 622019 [details] [diff] [review]
part 2, simplify IntersectRect calculations

I guess the compiler can optimize away the unnecessary initialization and
IsEmpty() calculation, it's just simpler to not do it.
Comment 3 Mats Palmgren (vacation) 2012-05-08 09:59:24 PDT
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=ef827e2cdd2d

Note You need to log in before you can comment on or make changes to this bug.