752986 - [AccessFu] Use left right D-Pad keys for content navigation

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Right now it is up/down. Pros/cons for changing this.
pro: getting back to the awesome bar is just one button press away.
pro: the virtual cursor position would be retained when navigating in
and out of the awesome bar.
con: feels to me counter intuitive.
con: don't know what to do about rtl setups.

After dicussing this with Marco, it makes sense to go ahead with it. VoiceOver uses left/right for content nav too. rtl should not be a real issue.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Retouched the comment there too, for some style consistency.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

OK, I tested it this time :)

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Review of attachment 622054 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/VirtualCursorController.jsm
@@ +59,5 @@
> +        if (Services.appinfo.OS == 'Android')
> +          // Return focus to browser chrome, which in Android is a native widget.
> +          Cc['@mozilla.org/android/bridge;1'].
> +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));

Do you need to set the virtual cursor position to null here?

@@ +65,3 @@
>        case aEvent.DOM_VK_RETURN:
> +        // XXX: It is true that desktop does not map the kp enter key to ENTER.
> +        // So for desktop we require a ctrl+return instead.

BTW what is "kp" enter key?

Comment 4

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #3)
> Comment on attachment 622054 [details] [diff] [review]
> Bug 752986 - Change VC nav to left/right instead of up/down. Correct
> home/end constant names.
> 
> Review of attachment 622054 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/VirtualCursorController.jsm
> @@ +59,5 @@
> > +        if (Services.appinfo.OS == 'Android')
> > +          // Return focus to browser chrome, which in Android is a native widget.
> > +          Cc['@mozilla.org/android/bridge;1'].
> > +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
> 
> Do you need to set the virtual cursor position to null here?
> 

No. The added benefit of this change is you get to keep your place in the doc even if you navigate up to the awesomebar and back. So setting it to null wouldn't be good here.

> @@ +65,3 @@
> >        case aEvent.DOM_VK_RETURN:
> > +        // XXX: It is true that desktop does not map the kp enter key to ENTER.
> > +        // So for desktop we require a ctrl+return instead.
> 
> BTW what is "kp" enter key?

the d-pad center button is mapped to the keypad enter (kp), instead of the regular return. I could expand the acronym..

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Great. r=me

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to David Bolter [:davidb] from comment #3)
> > Comment on attachment 622054 [details] [diff] [review]

> > > +          Cc['@mozilla.org/android/bridge;1'].
> > > +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > > +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
> > 
> > Do you need to set the virtual cursor position to null here?
> > 
> 
> No. The added benefit of this change is you get to keep your place in the
> doc even if you navigate up to the awesomebar and back. So setting it to
> null wouldn't be good here.

OK good that was my hunch, thanks.

> > BTW what is "kp" enter key?
> 
> the d-pad center button is mapped to the keypad enter (kp), instead of the
> regular return. I could expand the acronym..

Sure :)

Comment 6

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/075804813c58

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/075804813c58

Comment 8

[Marco Zehe (:MarcoZ)]

Verified in Fennec/15.0a1 2012-05-21