Closed
Bug 752986
Opened 13 years ago
Closed 13 years ago
[AccessFu] Use left right D-Pad keys for content navigation
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
VERIFIED
FIXED
mozilla15
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file, 1 obsolete file)
Right now it is up/down. Pros/cons for changing this.
pro: getting back to the awesome bar is just one button press away.
pro: the virtual cursor position would be retained when navigating in
and out of the awesome bar.
con: feels to me counter intuitive.
con: don't know what to do about rtl setups.
After dicussing this with Marco, it makes sense to go ahead with it. VoiceOver uses left/right for content nav too. rtl should not be a real issue.
Assignee | ||
Comment 1•13 years ago
|
||
Retouched the comment there too, for some style consistency.
Attachment #622046 -
Flags: review?(dbolter)
Assignee | ||
Updated•13 years ago
|
Attachment #622046 -
Attachment is obsolete: true
Attachment #622046 -
Flags: review?(dbolter)
Assignee | ||
Comment 2•13 years ago
|
||
OK, I tested it this time :)
Attachment #622054 -
Flags: review?(dbolter)
Comment 3•13 years ago
|
||
Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.
Review of attachment 622054 [details] [diff] [review]:
-----------------------------------------------------------------
::: accessible/src/jsat/VirtualCursorController.jsm
@@ +59,5 @@
> + if (Services.appinfo.OS == 'Android')
> + // Return focus to browser chrome, which in Android is a native widget.
> + Cc['@mozilla.org/android/bridge;1'].
> + getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> + JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
Do you need to set the virtual cursor position to null here?
@@ +65,3 @@
> case aEvent.DOM_VK_RETURN:
> + // XXX: It is true that desktop does not map the kp enter key to ENTER.
> + // So for desktop we require a ctrl+return instead.
BTW what is "kp" enter key?
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to David Bolter [:davidb] from comment #3)
> Comment on attachment 622054 [details] [diff] [review]
> Bug 752986 - Change VC nav to left/right instead of up/down. Correct
> home/end constant names.
>
> Review of attachment 622054 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: accessible/src/jsat/VirtualCursorController.jsm
> @@ +59,5 @@
> > + if (Services.appinfo.OS == 'Android')
> > + // Return focus to browser chrome, which in Android is a native widget.
> > + Cc['@mozilla.org/android/bridge;1'].
> > + getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > + JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
>
> Do you need to set the virtual cursor position to null here?
>
No. The added benefit of this change is you get to keep your place in the doc even if you navigate up to the awesomebar and back. So setting it to null wouldn't be good here.
> @@ +65,3 @@
> > case aEvent.DOM_VK_RETURN:
> > + // XXX: It is true that desktop does not map the kp enter key to ENTER.
> > + // So for desktop we require a ctrl+return instead.
>
> BTW what is "kp" enter key?
the d-pad center button is mapped to the keypad enter (kp), instead of the regular return. I could expand the acronym..
Comment 5•13 years ago
|
||
Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.
Great. r=me
(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to David Bolter [:davidb] from comment #3)
> > Comment on attachment 622054 [details] [diff] [review]
> > > + Cc['@mozilla.org/android/bridge;1'].
> > > + getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > > + JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
> >
> > Do you need to set the virtual cursor position to null here?
> >
>
> No. The added benefit of this change is you get to keep your place in the
> doc even if you navigate up to the awesomebar and back. So setting it to
> null wouldn't be good here.
OK good that was my hunch, thanks.
> > BTW what is "kp" enter key?
>
> the d-pad center button is mapped to the keypad enter (kp), instead of the
> regular return. I could expand the acronym..
Sure :)
Attachment #622054 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 6•13 years ago
|
||
Assignee: nobody → eitan
Target Milestone: --- → mozilla15
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•