The default bug view has changed. See this FAQ.

[AccessFu] Use left right D-Pad keys for content navigation

VERIFIED FIXED in mozilla15

Status

()

Core
Disability Access APIs
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla15
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Right now it is up/down. Pros/cons for changing this.
pro: getting back to the awesome bar is just one button press away.
pro: the virtual cursor position would be retained when navigating in
and out of the awesome bar.
con: feels to me counter intuitive.
con: don't know what to do about rtl setups.

After dicussing this with Marco, it makes sense to go ahead with it. VoiceOver uses left/right for content nav too. rtl should not be a real issue.
(Assignee)

Comment 1

5 years ago
Created attachment 622046 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Retouched the comment there too, for some style consistency.
Attachment #622046 - Flags: review?(dbolter)
(Assignee)

Updated

5 years ago
Attachment #622046 - Attachment is obsolete: true
Attachment #622046 - Flags: review?(dbolter)
(Assignee)

Comment 2

5 years ago
Created attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

OK, I tested it this time :)
Attachment #622054 - Flags: review?(dbolter)
Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Review of attachment 622054 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/VirtualCursorController.jsm
@@ +59,5 @@
> +        if (Services.appinfo.OS == 'Android')
> +          // Return focus to browser chrome, which in Android is a native widget.
> +          Cc['@mozilla.org/android/bridge;1'].
> +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));

Do you need to set the virtual cursor position to null here?

@@ +65,3 @@
>        case aEvent.DOM_VK_RETURN:
> +        // XXX: It is true that desktop does not map the kp enter key to ENTER.
> +        // So for desktop we require a ctrl+return instead.

BTW what is "kp" enter key?
(Assignee)

Comment 4

5 years ago
(In reply to David Bolter [:davidb] from comment #3)
> Comment on attachment 622054 [details] [diff] [review]
> Bug 752986 - Change VC nav to left/right instead of up/down. Correct
> home/end constant names.
> 
> Review of attachment 622054 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/VirtualCursorController.jsm
> @@ +59,5 @@
> > +        if (Services.appinfo.OS == 'Android')
> > +          // Return focus to browser chrome, which in Android is a native widget.
> > +          Cc['@mozilla.org/android/bridge;1'].
> > +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
> 
> Do you need to set the virtual cursor position to null here?
> 

No. The added benefit of this change is you get to keep your place in the doc even if you navigate up to the awesomebar and back. So setting it to null wouldn't be good here.

> @@ +65,3 @@
> >        case aEvent.DOM_VK_RETURN:
> > +        // XXX: It is true that desktop does not map the kp enter key to ENTER.
> > +        // So for desktop we require a ctrl+return instead.
> 
> BTW what is "kp" enter key?

the d-pad center button is mapped to the keypad enter (kp), instead of the regular return. I could expand the acronym..
Comment on attachment 622054 [details] [diff] [review]
Bug 752986 - Change VC nav to left/right instead of up/down. Correct home/end constant names.

Great. r=me

(In reply to Eitan Isaacson [:eeejay] from comment #4)
> (In reply to David Bolter [:davidb] from comment #3)
> > Comment on attachment 622054 [details] [diff] [review]

> > > +          Cc['@mozilla.org/android/bridge;1'].
> > > +            getService(Ci.nsIAndroidBridge).handleGeckoMessage(
> > > +              JSON.stringify({ gecko: { type: 'ToggleChrome:Focus' } }));
> > 
> > Do you need to set the virtual cursor position to null here?
> > 
> 
> No. The added benefit of this change is you get to keep your place in the
> doc even if you navigate up to the awesomebar and back. So setting it to
> null wouldn't be good here.

OK good that was my hunch, thanks.

> > BTW what is "kp" enter key?
> 
> the d-pad center button is mapped to the keypad enter (kp), instead of the
> regular return. I could expand the acronym..

Sure :)
Attachment #622054 - Flags: review?(dbolter) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/075804813c58
Assignee: nobody → eitan
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/075804813c58
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 8

5 years ago
Verified in Fennec/15.0a1 2012-05-21
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.